Skip to content

fix(tests): un-hardcode the PreCompact fixture timestamp (time bomb breaking main since 2026-09-05) - #11

Merged
copeus merged 1 commit into
procoders:mainfrom
khymerao:fix/native-points-time-bomb
Sep 11, 2026
Merged

copeus merged 1 commit into
procoders:mainfrom
khymerao:fix/native-points-time-bomb

Conversation

@khymerao

@khymerao khymerao commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

У тесті лежала фікстура з жорстко вписаною датою - updated_at: "2026-09-02T00:00:00Z".
Знайшов під час ребейзу #4 - червоне CI там саме через це, а не через той PR.

tests/test-native-points.sh failed on main from 2026-09-05 with:
  FAIL PRECOMPACT: takes a snapshot when work is unfinished
  FAIL THE CALLER: PostCompact reports the SNAPSHOT, not the changed disk

Root cause: the PreCompact run fixture hardcoded
updated_at: "2026-09-02T00:00:00Z". The chain under test goes
precompact-snapshot.sh -> compound-v-dashboard.py resume, and resume filters on
DEFAULT_RESUME_MAX_AGE_HOURS = 72.0. Once wall-clock passed 72h after that
literal date, resume returned empty, so the hook wrote no snap-* file and the
PostCompact reader had nothing to read. Both assertions then failed - not a
flake, a date-triggered break that would have stayed broken.

Proof: same fixture with --max-age-hours 100000 prints
'UNFINISHED COMPOUND V WORK ... updated 3d ago'; with the default window it
prints nothing.

Fix: generate updated_at with now_ts(), which the file's three other run
fixtures (lines 119, 395, 461) already do. This one was the only literal.

tests/test-native-points.sh: 128 passed, 0 failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants