fix(tests): un-hardcode the PreCompact fixture timestamp (time bomb breaking main since 2026-09-05) - #11
Merged
Conversation
tests/test-native-points.sh failed on main from 2026-09-05 with: FAIL PRECOMPACT: takes a snapshot when work is unfinished FAIL THE CALLER: PostCompact reports the SNAPSHOT, not the changed disk Root cause: the PreCompact run fixture hardcoded updated_at: "2026-09-02T00:00:00Z". The chain under test goes precompact-snapshot.sh -> compound-v-dashboard.py resume, and resume filters on DEFAULT_RESUME_MAX_AGE_HOURS = 72.0. Once wall-clock passed 72h after that literal date, resume returned empty, so the hook wrote no snap-* file and the PostCompact reader had nothing to read. Both assertions then failed - not a flake, a date-triggered break that would have stayed broken. Proof: same fixture with --max-age-hours 100000 prints 'UNFINISHED COMPOUND V WORK ... updated 3d ago'; with the default window it prints nothing. Fix: generate updated_at with now_ts(), which the file's three other run fixtures (lines 119, 395, 461) already do. This one was the only literal. tests/test-native-points.sh: 128 passed, 0 failed.
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
У тесті лежала фікстура з жорстко вписаною датою -
updated_at: "2026-09-02T00:00:00Z".Знайшов під час ребейзу #4 - червоне CI там саме через це, а не через той PR.