Skip to content

fix(auth): preserve padded message cookie values #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Aug 1, 2026
+14 −1
Merged

fix(auth): preserve padded message cookie values #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/api/chat/messages/[id]/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ async function authenticateUser(request) {
return null;
}

const token = sessionCookie.split('=')[1];
const separatorIndex = sessionCookie.indexOf('=');
const token = separatorIndex >= 0 ? sessionCookie.slice(separatorIndex + 1) : '';
if (!token) {
return null;
}
Expand Down
12 changes: 12 additions & 0 deletions src/app/api/chat/messages/[id]/route.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,18 @@ describe('GET /api/chat/messages/[id]', () => {
expect(mocks.messageEq).toHaveBeenCalledWith('id', 'message-1');
});

it('preserves padded auth cookie values when verifying the session', async () => {
const { GET } = await import('./route.js');
await GET(
new Request('https://qrypt.chat/api/chat/messages/message-1', {
headers: { cookie: 'sb-access-token=valid-token==' }
}),
{ params: Promise.resolve({ id: 'message-1' }) }
);

expect(mocks.authGetUser).toHaveBeenCalledWith('valid-token==');
});

it('rejects missing async route params before authentication', async () => {
const { GET } = await import('./route.js');
const response = await GET(new Request('https://qrypt.chat/api/chat/messages/'), {
Expand Down
Loading