[8.x] Get 8.x passing again in CI (address failed checks caused by updates to Rubocop, Solr, ViewComponent) by seanaery · Pull Request #3883 · projectblacklight/blacklight

seanaery · 2026-07-17T16:32:13Z

fix rubocop violations
add Solr 10 support
fix a helper spec that had started failing with view_component 3.x with 3.25.0+

- autocorrected new issues - regenerated a fresh .rubocop_todo.yml via `--auto-gen-config`

- In Solr 10, `handleSelect="true"` in `<requestDispatcher>` was removed. - That was the old mechanism that forwarded `/select` requests to the `default="true"` handler (named `"search"`). In Solr 10 you must have an explicit `/select` handler.

- test had begun failing w/VC 3.25.0 release (Jun 2026) - specific VC change `Fix stale render context on reused component instances` is the culprit; it resets helpers on every render, causing collection components rendered from a plain ActionView template to fall back to controller#view_context, which lacks the `blacklight_config` stub, so it raises a `NameError` - stubbing `controller#view_context` to return helper ensures it resolves correctly

cjcolvar

Thanks for working on this! I see the build is green but I'm slightly concerned about a drift in configuration between main and the 8.x branch. Would it be possible to backport #3806 and #3819 so the solr configs and rubocop configs stay aligned?

cjcolvar · 2026-07-20T13:57:19Z


  <requestHandler name="/replication" class="solr.ReplicationHandler" startup="lazy" />

-  <requestDispatcher handleSelect="true" >


FWIW main still has this handleSelect="true" in its solrconfig. Maybe it should be removed it from there too?

cjcolvar · 2026-07-20T14:09:35Z

+      # In ViewComponent 3.25.0+, collection components rendered from a plain
+      # ActionView template fall back to controller.view_context for helpers
+      # instead of the stubbed helper. Workaround not needed on 2.x or 4.x.
+      if ViewComponent::VERSION::MAJOR == 3
+        allow(controller).to receive(:view_context).and_return(helper)
+      end


Nice catch!

This is no longer a recommended or default configuration, and Solr actively discourages it.

We don't use this for anything

…tocorrect

… & Rails 8.1.

skypack has an outage.

… an asset manifest. - fixes CI test failures impacting Rails 8.x without `--css=bootstrap`: Expected to find a manifest file in `app/assets/config/manifest.js` (Sprockets::Railtie::ManifestNeededError)

seanaery · 2026-07-23T02:51:22Z

Thanks @cjcolvar for the good feedback. I have made more changes in response (including cherry-picking a few relevant commits from main) to address those drift concerns and get this more aligned with what’s currently on main. That of course has turned this into a much bigger PR (now 78 files changed) :-)

Solr Configs

schema.xml is now identical to what's on main.
solrconfig.xml is now almost identical to main. I left in the BL8 /advanced requestHandler, as BL9 included a lot of Advanced Search refactoring that likely shouldn’t be backported. And yes, <requestDispatcher handleSelect="true"> should be removed from main, as that has been obsolete since Solr 7.

Rubocop

.rubocop.yml is now identical to what’s on main.

Test Matrix

I added some Ruby 3.4 & Rails 8.1 scenarios to the matrix and dropped Ruby 3.1.
I also added a scenario that verifies that a Rails 8.x + BL8 app generation still works without the --css=bootstrap option; this required some shims in the ImportmapGenerator to ensure the Sprockets fallbacks for CSS actually work.
Since BL8 is naturally more permissive than BL9 on some dependency versions (esp. Bootstrap 4-5; ViewComponent 2-4; Sprockets still semi-supported) it was a little tricky to get all tests passing, but it is now green again.

cjcolvar

Amazing work! ✨

This definitely was a lot more than I was originally thinking when I suggested the cherry-picking. Thanks for devoting this much to it! I think this puts the community in a good position for helping those who are still on 8.x (including me 🙂).

seanaery added 2 commits July 17, 2026 12:27

Fix rubocop violations causing failed lint jobs in CI for 8.x

26206d1

- autocorrected new issues - regenerated a fresh .rubocop_todo.yml via `--auto-gen-config`

Add Solr 10 support to fix CI.

fa1df27

- In Solr 10, `handleSelect="true"` in `<requestDispatcher>` was removed. - That was the old mechanism that forwarded `/select` requests to the `default="true"` handler (named `"search"`). In Solr 10 you must have an explicit `/select` handler.

seanaery force-pushed the fix-8x-ci branch 4 times, most recently from 63669c6 to 1d02317 Compare July 17, 2026 21:25

seanaery force-pushed the fix-8x-ci branch from 1d02317 to ae18ce0 Compare July 20, 2026 01:49

seanaery changed the title ~~[8.x] Fix rubocop violations causing failed lint jobs in CI for 8.x~~ [8.x] Get 8.x passing again in CI (address failed checks caused by updates to Rubocop, Solr, ViewComponent) Jul 20, 2026

seanaery marked this pull request as ready for review July 20, 2026 12:25

cjcolvar reviewed Jul 20, 2026

View reviewed changes

cbeer and others added 6 commits July 21, 2026 21:46

Remove enableRemoteStreaming from solrconfig (#3791)

be650da

This is no longer a recommended or default configuration, and Solr actively discourages it.

Apply consistent formatting to solr configs

fb43d3b

Remove active_fedora_model_ssi from solrconfig

7f4a219

We don't use this for anything

Configuration for Solr 10, drop Solr 8 support

f0cde4a

Stop testing on Solr 8 (EOL 2024); but ensure we test on 9

09b1987

[8.x] backport rubocop.yml config from main to reduce drift; run au…

e59049b

…tocorrect

seanaery force-pushed the fix-8x-ci branch from 81501da to 5929a3a Compare July 22, 2026 10:52

Update CI test matrix: drop Ruby 3.1 (EOL Mar 2025); test on Ruby 3.4…

cfdd775

… & Rails 8.1.

seanaery force-pushed the fix-8x-ci branch 2 times, most recently from efcb154 to 13b7c12 Compare July 22, 2026 13:45

Replace skypack.dev with jsdeliver

2fd83d6

skypack has an outage.

seanaery force-pushed the fix-8x-ci branch 3 times, most recently from 441d0c6 to 45e217c Compare July 22, 2026 19:00

Ensure that environments still using sassc-rails/sprockets-rails have…

16791fa

… an asset manifest. - fixes CI test failures impacting Rails 8.x without `--css=bootstrap`: Expected to find a manifest file in `app/assets/config/manifest.js` (Sprockets::Railtie::ManifestNeededError)

seanaery force-pushed the fix-8x-ci branch from 45e217c to 16791fa Compare July 23, 2026 02:16

cjcolvar approved these changes Jul 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[8.x] Get 8.x passing again in CI (address failed checks caused by updates to Rubocop, Solr, ViewComponent) - #3883

[8.x] Get 8.x passing again in CI (address failed checks caused by updates to Rubocop, Solr, ViewComponent)#3883
seanaery wants to merge 12 commits into
release-8.xfrom
fix-8x-ci

seanaery commented Jul 17, 2026 •

edited

Loading

Uh oh!

cjcolvar left a comment

Uh oh!

cjcolvar Jul 20, 2026

Uh oh!

cjcolvar Jul 20, 2026

Uh oh!

seanaery commented Jul 23, 2026

Uh oh!

cjcolvar left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		<requestHandler name="/replication" class="solr.ReplicationHandler" startup="lazy" />

		<requestDispatcher handleSelect="true" >

Uh oh!

Conversation

seanaery commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjcolvar left a comment

Choose a reason for hiding this comment

Uh oh!

cjcolvar Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

cjcolvar Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

seanaery commented Jul 23, 2026

Solr Configs

Rubocop

Test Matrix

Uh oh!

cjcolvar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

seanaery commented Jul 17, 2026 •

edited

Loading