Skip to content

Stop testing on rails 7.2 - #3884

Merged
seanaery merged 1 commit into
mainfrom
jcoyne-patch-2
Jul 31, 2026
Merged

Stop testing on rails 7.2#3884
seanaery merged 1 commit into
mainfrom
jcoyne-patch-2

Conversation

@jcoyne

@jcoyne jcoyne commented Jul 31, 2026

Copy link
Copy Markdown
Member

Rails 7.2 is EOL as of Aug 9, 2026 https://endoflife.date/rails

Rails 7.2 is EOL as of Aug 9, 2026 https://endoflife.date/rails

@seanaery seanaery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping on top of this. As part of this removal -- or as a followup PR -- can we add the -a propshaft to one of the remaining test scenarios? If I understand correctly, I think this 7.2 scenario is the only one in the matrix currently testing the PropshaftGenerator.

@jcoyne

jcoyne commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

@seanaery propshaft is the default in Rails 8.

@seanaery

Copy link
Copy Markdown
Contributor

@jcoyne Oh right -- thanks! Now I see that all the remaining Rails 8 scenarios that specify --js=esbuild are indeed doing generate blacklight:assets:propshaft and the rest are doing generate blacklight:assets:importmap.

@seanaery
seanaery merged commit 031499f into main Jul 31, 2026
14 checks passed
@seanaery
seanaery deleted the jcoyne-patch-2 branch July 31, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants