Stop testing on rails 7.2 - #3884
Merged
Merged
Conversation
Rails 7.2 is EOL as of Aug 9, 2026 https://endoflife.date/rails
seanaery
reviewed
Jul 31, 2026
seanaery
left a comment
Contributor
There was a problem hiding this comment.
Thanks for keeping on top of this. As part of this removal -- or as a followup PR -- can we add the -a propshaft to one of the remaining test scenarios? If I understand correctly, I think this 7.2 scenario is the only one in the matrix currently testing the PropshaftGenerator.
Member
Author
|
@seanaery propshaft is the default in Rails 8. |
Contributor
|
@jcoyne Oh right -- thanks! Now I see that all the remaining Rails 8 scenarios that specify |
seanaery
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 7.2 is EOL as of Aug 9, 2026 https://endoflife.date/rails