ci: resolve PR number from head SHA in benchmark report#2278
Merged
Conversation
workflow_run.pull_requests is empty when the triggering run's head
branch is not on the default branch (or when the PR is from a fork),
so the report job produced a malformed URL and failed to comment on
the PR. Fall back to resolving the PR via the commits/{sha}/pulls
endpoint, and fail loudly if it still can't be determined.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
jaydeluca
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
PR Benchmark Reportworkflow failed to comment on #2252 after a successful benchmark run (run 28865892835):Root cause:
workflow_run.pull_requestsis empty when the triggering run's head branch is not on the default branch (or the PR is from a fork). WithPR_NUMBERempty, the subsequentrepos/${REPO}/issues//commentsAPI call 404s and the paginator emits a malformed URL, so no comment gets posted.Changes
repos/{owner}/{repo}/commits/{sha}/pullsto resolve the PR from the head SHA whenworkflow_run.pull_requestsis empty.Test plan