Skip to content

fix(bayn): preserve local candidate decision status - #13475

Merged
gregkonush merged 7 commits into
mainfrom
codex/bayn-local-development-receipts
Aug 2, 2026
Merged

fix(bayn): preserve local candidate decision status#13475
gregkonush merged 7 commits into
mainfrom
codex/bayn-local-development-receipts

Conversation

@gregkonush

@gregkonush gregkonush commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a compact v3 local-development receipt domain that binds reviewed source revision, blobs, hashes, attempt ordinal, terminal PASS/HOLD_REJECT/FAILED status, and terminal report hash.
  • Keep runtime market-data path/content and full metric output out of the receipt.
  • Keep the Effect interpreter cohesive with explicit dependency injection, reserve-before-execute ordering, one finalization, O_EXCL crash burning, interruption failure finalization, source-scoped legacy-receipt compatibility across the main worktree and registered linked-worktree admin records (including prunable records), evaluator-source revalidation, directory-sync durability, and shared legacy/v3 ordinal claim coordination.
  • Keep the documented package script contract and route its existing wrapper entrypoint in-process to the service-owned interpreter.

Related Issues

None

Testing

  • Focused service receipt tests: 16 passed, 37 assertions.
  • Focused scripts-wrapper compatibility tests: 14 passed, 36 assertions; existing qualification contract tests: 17 passed, 90 assertions.
  • Full local Bayn suite at the final local head: 1,242 passed, 153 skipped, 0 failed across 116 files; 8,809 assertions.
  • Final-head CI is required after this final review-fix head: full PR checks, real PostgreSQL integration, both Bayn image builds, dependency invariant, broker sandbox, Effect compatibility, and release gate.
  • Service typecheck, Effect diagnostics, lint, Oxlint, format, and build passed; one pre-existing Bayn Oxlint warning remains outside this change in src/candidate-development-domain/preflight.ts.
  • Package-wide TypeScript checking still reports unrelated existing errors outside this lane; the changed local command has no remaining package-tsc diagnostic.
  • No candidate, holdout, broker, or access-data execution occurred; full-suite evidence uses repository test fixtures only.

Breaking Changes

None

Checklist

  • Testing section documents exact validation performed.
  • Screenshots and Breaking Changes handled.
  • Documentation, release notes, follow-ups updated/tracked.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01ba322724

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/bayn/src/candidate-development-local/command.ts Outdated
@gregkonush
gregkonush force-pushed the codex/bayn-local-development-receipts branch from 01ba322 to 80085b7 Compare August 2, 2026 08:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80085b78a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/bayn/src/candidate-development-local/command.ts Outdated
Comment thread services/bayn/src/candidate-development-local/command.ts Outdated
Comment thread services/bayn/package.json Outdated
@gregkonush
gregkonush force-pushed the codex/bayn-local-development-receipts branch 2 times, most recently from 9a08fa6 to 7346dbe Compare August 2, 2026 08:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7346dbef6d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/bayn/src/candidate-development-local/command.ts Outdated
Comment thread services/bayn/src/candidate-development-local/command.ts Outdated
@gregkonush
gregkonush force-pushed the codex/bayn-local-development-receipts branch 3 times, most recently from 87f609e to 0c244bc Compare August 2, 2026 09:20
@gregkonush
gregkonush force-pushed the codex/bayn-local-development-receipts branch from 0c244bc to 69f6ee2 Compare August 2, 2026 09:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69f6ee223a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/bayn/src/candidate-development-local/command.ts Outdated
Comment thread services/bayn/src/candidate-development-local/command.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 051746efa1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/bayn/src/candidate-development-local/command.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b92f7e23b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/bayn/src/candidate-development-local/command.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0b6ddf9ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/bayn/src/candidate-development-local/command.ts
Comment thread services/bayn/src/candidate-development-local/command.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ecad4b74bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/bayn/src/candidate-development-local/command.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: feffd9f2ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/bayn/src/candidate-development-local/command.ts Outdated
@gregkonush
gregkonush enabled auto-merge (squash) August 2, 2026 10:45
@gregkonush
gregkonush merged commit 8bafccc into main Aug 2, 2026
19 checks passed
@gregkonush
gregkonush deleted the codex/bayn-local-development-receipts branch August 2, 2026 10:46
@gregkonush
gregkonush restored the codex/bayn-local-development-receipts branch August 2, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant