refactor(bayn): unify candidate lifecycle authority - #13477
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa75cfb2d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aa75cfb to
8afa99d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8afa99d071
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
nextCandidatePreregistrationalone is never ready.PRECOMMIT_INVALID/UNATTEMPTEDand next ordinal 21.Related Issues
None
Testing
bun test services/bayn/src/candidate-development-trials/state-machine.test.ts services/bayn/src/candidate-development-trials/qualification-dormancy.test.ts— 13 passed.bun run --filter @proompteng/bayn test— 1,224 passed, 153 skipped, 0 failed across 1,377 tests. PostgreSQL tests are unrelated to this pure domain-only patch and remained skipped by the suite.bun run --filter @proompteng/bayn tsc— passed.bun run --filter @proompteng/bayn lint— passed.bun run --filter @proompteng/bayn lint:oxlintandlint:oxlint:type— passed with one pre-existing warning outside scope incandidate-development-domain/preflight.ts.bunx oxfmt --checkon all nine changed lifecycle files — passed.bun run --filter @proompteng/bayn build— passed.Breaking Changes
None. Integration must pass the canonical
CandidateDevelopmentTrialStateproduced/reduced bystate-machine.tstoqualificationDormancyDecisionFromState; history normalization intentionally remains development-pending even whennextCandidatePreregistrationis present.Checklist