Added overline underline and strike in text overlay - #1602
Open
niravasher wants to merge 7 commits into
Open
Conversation
Author
strike
overline
underline |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
==========================================
- Coverage 66.67% 65.41% -1.27%
==========================================
Files 130 132 +2
Lines 2686 2741 +55
Branches 433 438 +5
==========================================
+ Hits 1791 1793 +2
- Misses 895 948 +53 🚀 New features to boost your workflow:
|
rishabhshuklax
requested changes
Feb 1, 2020
niravasher
force-pushed
the
text-overlay
branch
from
February 1, 2020 19:25
3c7675d to
ef94a12
Compare
Author
|
|
rishabhshuklax
requested changes
Feb 2, 2020
| var options = { text : 'Hello World', size : '12'}; | ||
| where `options` is an object with the following property: | ||
| * options.text : It allows to enter input text for overlay. | ||
| * options.y : The value at which the overlay should start in x-axis. |
Member
There was a problem hiding this comment.
Shouldn't this be options.x?
Member
There was a problem hiding this comment.
You also need to fix this typo
| "strike" | ||
| ] | ||
| }, | ||
| "line_width": { |
Member
There was a problem hiding this comment.
Isn't this the height of the line, no?
niravasher
force-pushed
the
text-overlay
branch
from
February 3, 2020 18:21
dd7589c to
fad0e3a
Compare
Author
|
Fixed the silly mistakes @blurry-x-face |
rishabhshuklax
requested changes
Feb 3, 2020
rishabhshuklax
left a comment
rishabhshuklax
left a comment
Member
There was a problem hiding this comment.
Just a few more changes
| var options = { text : 'Hello World', size : '12'}; | ||
| where `options` is an object with the following property: | ||
| * options.text : It allows to enter input text for overlay. | ||
| * options.y : The value at which the overlay should start in x-axis. |
Member
There was a problem hiding this comment.
You also need to fix this typo
niravasher
force-pushed
the
text-overlay
branch
from
February 4, 2020 12:39
485743d to
8bfe03c
Compare
Author
|
Updated PR once again @blurry-x-face |
niravasher
force-pushed
the
text-overlay
branch
from
February 4, 2020 15:34
bbaef5b to
1517147
Compare
Author
|
done @blurry-x-face |
|
|
harshkhandeparkar
added
the
almost-complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1585 (<=== Replace
0000with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!