Add missing codecov gem to unblock SimpleCov coverage reporting - #293
Merged
Conversation
spec_helper.rb's SIMPLECOV=yes gate (via puppetlabs_spec_helper's module_spec_helper) requires simplecov, simplecov-console, and codecov to all be loadable. simplecov-console was already declared here and simplecov was present transitively, but codecov was missing entirely, so running with SIMPLECOV=yes raised a LoadError instead of producing a coverage report. With this gem added, `SIMPLECOV=yes bundle exec rake spec` now correctly reports coverage (82.02% line coverage as of this change). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
david22swan
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec_helper.rb'sSIMPLECOV=yesgate (viapuppetlabs_spec_helper'smodule_spec_helper) requiressimplecov,simplecov-console, andcodecovto all be loadable.simplecov-consolewas already declared in the Gemfile andsimplecovwas present only transitively, butcodecovwas missing entirely. This PR addsgem "codecov", '~> 0.6', require: falseto the Gemfile's:developmentgroup — no other changes.Additional Context
SIMPLECOV=yes bundle exec rake speconmainraisesLoadError: cannot load such file -- codecovatspec_helper.rb:7, whichpuppetlabs_spec_helperwraps into a generic "add the simplecov, simplecov-console, codecov gems to Gemfile" error. Surfaced during a DevX coverage audit across PDK/Bolt-adjacent tooling (PPM-1579).codecovis required by the existing gate but was never added as a dependency — this just supplies the missing piece rather than changing any gating behavior.Related Issues (if any)
Surfaced as part of PPM-1579 (Quality Improvements for H2 2026) coverage audit — no existing issue filed against this repo specifically.
Checklist
SIMPLECOV=yes bundle exec rake specnow completes and reports 82.02% line coverage (406/495) instead of erroring. Note: 3 pre-existing failures inspec/integration/puppetcore_spec.rb(missingPUPPET_FORGE_TOKENenv var) are unrelated to this change.ci.yml), not independently verified against 3.1 but this is a pure Gemfile dependency addition with no version-specific code.