chore: bring cosmos/evm v0.6.2 onto testnet/donut - #353
Merged
Conversation
Points the evm replace at push-chain-evm develop f6a1ba72, which is cosmos/evm v0.6.2. No node code changes were required.
chore: bump cosmos/evm pin to v0.6.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
develop(now on cosmos/evm v0.6.2) ontotestnet/donut.Branch was cut from
develop, thentestnet/donutmerged into it, so this PR lands clean.Contents
Two commits from develop:
81ba8602chore: bump cosmos/evm pin to v0.6.2b6529dd7merge of chore: bump cosmos/evm pin to v0.6.2 #352Net effect on donut is the
replacepin:2d248e1881bb(v0.6.0) →f6a1ba7250e2(v0.6.2).Verified locally
evmv060.NewUpgrade()includedgo build ./...cleanFull suite left to CI.
Behavioural notes for donut
No state migration. No proto change, no
ConsensusVersionbump, no store keys added/removed on eitherside of v0.6.0 → v0.6.2.
What actually changes at runtime:
SubBalancenow panics on underflow instead of wrapping silently. This is the upstream equivalent ofour F-2026-18201 statedb fix. A panic in a tx fails that tx (no halt), but any flow currently
underflowing silently would start failing visibly.
3524ebc6).Verified not to affect Push: all module-sender EVM calls pass
value=0, and theCallExecuteUniversalTx+DeductGasFeesFromReceiptcombination in the inbound path is exercised byTestInboundCEAGasAndPayload/TestInboundCEAFundsAndPayloadwith 0 occurrences ofnot allowed to receive funds.DeductAndBurnFeesuses the bank keeper, which never enters the EVMstatedb path at all.
vm.ErrOutOfGas— different error on calls that were alreadyrunning out of gas; no repricing, succeeding txs consume identical gas.
ExtendedDenom == Denom == upc, and the new codeis guarded by
if GetEVMCoinExtendedDenom() != GetEVMCoinDenom().Still to do before deployment (not in this PR)
evm-v0.6.2upgrade handler, following theevm-v0.6.0precedent (emptyStoreUpgrades, named planonly so cosmovisor has something to switch on)