Expose trace storage traits for custom sequential runners - #77
Open
twiecki wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
===========================================
- Coverage 83.77% 66.85% -16.93%
===========================================
Files 8 34 +26
Lines 1923 9413 +7490
===========================================
+ Hits 1611 6293 +4682
- Misses 312 3120 +2808 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom sequential runners can create a chain through the public API, but cannot use the existing Arrow (or other) trace backends because
StorageConfig,TraceStorage, andChainStorageare hidden behind a private module. Extracting per-draw statistics also needs the unexportedStatsDims.Re-export those existing types without changing their implementations. This lets a WASM runner call
expanded_draw, record the returned values and statistics throughArrowConfig, and produce the same Arrow trace used by Nutpie instead of implementing a separate storage backend.Validated with an external-crate regression test (
cargo test --no-default-features --features arrow --test public_storage_api) and a release WASM adapter that records and serializes the resulting traces. The browser integration lives separately in https://github.com/pymc-labs/nuts-rs-wasm.