Skip to content

gdbserver: honor resume_on_disconnect on last client detach #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhqian wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −15
Open

gdbserver: honor resume_on_disconnect on last client detach #2020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions pyocd/gdbserver/gdbserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# Copyright (c) 2006-2020,2025-2026 Arm Limited
# Copyright (c) 2021-2022 Chris Reed
# Copyright (c) 2022 Clay McClure
# Copyright (c) 2026 Ryan QIAN
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -578,21 +579,23 @@ def notify_client_detached(self, client: GDBClientSession):
self.did_init_thread_providers = False
self.first_run_after_reset_or_flash = True

# Resume target when no clients are connected
try:
# First check if it's halted
if self.target.get_state() == Target.State.HALTED:
# If the target is halted, flush the trace capture buffer.
if self.is_target_running:
self.is_target_running = False
self.trace_flush()
# Start trace capture before resuming.
self.trace_capture()
self.target.resume()
except Exception as e:
LOG.error("Error resuming target after client detached: %s",
e, exc_info=self.session.log_tracebacks)
self.is_target_running = (self.target.get_state() == Target.State.RUNNING)
# Resume target when no clients are connected, unless the
# resume_on_disconnect session option is False.
if self.session.options.get('resume_on_disconnect', True):
try:
# First check if it's halted
if self.target.get_state() == Target.State.HALTED:
# If the target is halted, flush the trace capture buffer.
if self.is_target_running:
self.is_target_running = False
self.trace_flush()
# Start trace capture before resuming.
self.trace_capture()
self.target.resume()
except Exception as e:
LOG.error("Error resuming target after client detached: %s",
e, exc_info=self.session.log_tracebacks)
self.is_target_running = (self.target.get_state() == Target.State.RUNNING)

# Decide server lifecycle on connected sessions
if not self.client_sessions and not self.persist:
Expand Down
Loading