Allow dotted namespace package names in flit init (#679) - #822
Open
CyberneticX-Tech wants to merge 1 commit into
Open
Allow dotted namespace package names in flit init (#679)#822CyberneticX-Tech wants to merge 1 commit into
CyberneticX-Tech wants to merge 1 commit into
Conversation
Validate module names by ensuring each dot-separated component is a valid identifier, allowing namespace packages like 'my_org.my_pkg'. Closes pypa#679.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #679.
flit initpreviously usedstr.isidentifieras the validator for the interactive module name prompt, which rejected valid Python namespace packages containing dot separators (such asmy_org.my_pkgorns.subpkg).This change introduces
validate_module_nameinIniterBase, ensuring that every dot-separated segment is a valid Python identifier while disallowing empty components or leading/trailing dots.Changes
IniterBase.validate_module_name(s: str) -> boolvalidatingbool(s) and all(n.isidentifier() for n in s.split('.')).TerminalIniter.initialise()to useself.validate_module_namefor module name validation.tests/test_init.pycovering valid/invalid module name patterns and end-to-endflit initexecution with namespace packages.