Differentiate async authentication - #67
Open
JacobHenner wants to merge 1 commit into
Open
JacobHenner wants to merge 1 commit into
JacobHenner wants to merge 1 commit into
Conversation
Differentiate async auth, to ensure that any blocking IO performed during GSSAPI authentication (e.g. network interactions with a KDC) does not block the event loop.
aiudirog
self-requested a review
September 28, 2026 20:46
Member
|
@JacobHenner Thanks for addressing this. I'm playing with some variations locally to see how much we can avoid bifurcating the response handling to avoid any risk of it diverging in future refactors. I have a nested generator implementation where the thread targets are yielded alongside the requests, but MyPy really hates it lol, so I'm going to try again. |
Member
|
@JacobHenner I've sent you two different options for refactors the avoid duplicating the response handling. The first moves the auth flow generator to a background thread and uses two queues to get requests and put responses. The second pushes each step of the flow generator onto a thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differentiate async auth, to ensure that any blocking IO performed during GSSAPI authentication (e.g. network interactions with a KDC) does not block the event loop.