Skip to content

Events on hislip - #626

Open
hb020 wants to merge 9 commits into
pyvisa:mainfrom
hb020:events-on-hislip
Open

Events on hislip#626
hb020 wants to merge 9 commits into
pyvisa:mainfrom
hb020:events-on-hislip

Conversation

@hb020

@hb020 hb020 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor
  • Closes Allow events via hislip #625
  • Executed black . && isort -c . && flake8 with no errors. -> Is this still valid? It seems outdated.
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate. -> Looking where this might fit.
  • Added an entry to the CHANGES file

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.31250% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.32%. Comparing base (2c52aaa) to head (6f002f8).

Files with missing lines Patch % Lines
pyvisa_py/protocols/hislip.py 60.00% 49 Missing and 19 partials ⚠️
pyvisa_py/tcpip.py 46.66% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   41.73%   43.32%   +1.58%     
==========================================
  Files          29       29              
  Lines        5247     5473     +226     
  Branches      521      553      +32     
==========================================
+ Hits         2190     2371     +181     
- Misses       3030     3056      +26     
- Partials       27       46      +19     
Flag Coverage Δ
unittests 43.32% <70.31%> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hb020
hb020 marked this pull request as draft August 17, 2026 18:28
@hb020

hb020 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

oops, left some asserts in there. Will clean up

@hb020
hb020 marked this pull request as ready for review August 18, 2026 11:45
@hb020

hb020 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Don't like all those asserts, but there were already a fair amount of them, so I'll leave them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow events via hislip

1 participant