feat: DifferenceParameter phase updates - #757
Open
LaurenPetch1 wants to merge 6 commits into
Open
Conversation
LaurenPetch1
force-pushed
the
parameter-phase-updates
branch
from
August 19, 2026 12:34
b878e92 to
b4ff847
Compare
jetuk
requested changes
Aug 19, 2026
jetuk
left a comment
jetuk
left a comment
Member
There was a problem hiding this comment.
Implementation looks good. One comment about variable names.
| let built = match self.phase { | ||
| MetricConsumerPhase::Before => { | ||
| // We can make a simple version if all metrics can be simplified | ||
| let asimple: Result<SimpleMetricF64, _> = a.clone().try_into(); |
Member
There was a problem hiding this comment.
Real pedantic comment. I would prefer a_simple here, and for the following variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add phase options to DifferenceParameter. Also add parameter to schema