docs(contributing): the scope that counts is the one in the PR title - #178
Merged
Conversation
Today's per-chart colors PR was split into one commit per package precisely so each would get its own bump, and the squash merge threw the split away - the editor and the plugin landed as an indirect patch under a `chartkit-core` subject and had to be corrected with `overrides` at release time. `main` takes squash merges only, so that was never going to work rather than being bad luck. nx splits a scope on commas, verified against its matcher, so a multi-package feature names them all in the PR title. That is the whole fix.
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-chart colors PR was split into one commit per package so each would get
its own bump. The squash merge threw the split away: the editor and the plugin
landed as an indirect patch under a
chartkit-coresubject, and the releaseneeded
overridesto correct them - the hand-correction this repo has beentrying to stop needing.
maintakes squash merges only (allow_merge_commitandallow_rebase_mergeare both false), so one commit lands per PR with the title as its subject. The
split was never going to survive.
nx splits a scope on commas, so a multi-package feature names them all in the PR
title:
Verified with a dry run on a throwaway branch: both named packages take a minor
from one commit.
The section this amends was written this morning and is what led me straight
into the trap - it says to scope per package without saying which scope
survives.