Skip to content

perf(responder): precompute XML header bytes to avoid per-call allocation #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qm012 merged 1 commit into from
Sep 5, 2026
Merged

perf(responder): precompute XML header bytes to avoid per-call allocation #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion responder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ func JSON(w http.ResponseWriter, statusCode int, data any, opts ...JSONEncoderOp
return enc.Encode(data)
}

var xmlHeaderBytes = []byte(xml.Header)

// XML writes data as XML with the given status code.
func XML(w http.ResponseWriter, statusCode int, data any) error {
b, err := xml.Marshal(data)
Expand All @@ -59,7 +61,7 @@ func XML(w http.ResponseWriter, statusCode int, data any) error {
}
w.Header().Set("Content-Type", "application/xml; charset=utf-8")
w.WriteHeader(statusCode)
if _, err = w.Write([]byte(xml.Header)); err != nil {
if _, err = w.Write(xmlHeaderBytes); err != nil {
return err
}
_, err = w.Write(b)
Expand Down