Skip to content

drm/msm: Add Pakala (Adreno 830) GPU support - #1701

Merged
Komal Bajaj (Komal-Bajaj) merged 2 commits into
qualcomm-linux:tech/mm/gpufrom
quic-ksanadhy:tech/mm/gpu
Aug 21, 2026
Merged

drm/msm: Add Pakala (Adreno 830) GPU support#1701
Komal Bajaj (Komal-Bajaj) merged 2 commits into
qualcomm-linux:tech/mm/gpufrom
quic-ksanadhy:tech/mm/gpu

Conversation

@quic-ksanadhy

@quic-ksanadhy quic-ksanadhy commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Add support for the Pakala SoC's Adreno 830 GPU.

  • FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU
  • FROMLIST: dt-bindings: display/msm: Document Adreno 830 GPU/GMU

CRs-Fixed: 4647428

@qcomlnxci
qcomlnxci requested review from a team and Rajesh Kemisetti (quic-rajeshk) and removed request for a team August 17, 2026 11:17
@qlijarvis

qlijarvis commented Aug 17, 2026

Copy link
Copy Markdown

PR #1701 — validate-patch

PR: #1701

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: No — both commits use FROMLIST: prefix but lack required Link: tags
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot verify without lore links
  4. PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1701 - Add support for Adreno 830 GPU
Upstream commit: N/A (no lore links found)
Verdict: ❌ FAIL

Commit Message

Commit 1/2: FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU

Check Status Note
Subject matches upstream ⏭️ N/A No lore link to compare against
Body preserves rationale ⏭️ N/A No lore link to compare against
Fixes tag present/correct ⏭️ N/A Not applicable (new feature)
Authorship preserved ⏭️ N/A No lore link to compare against
Backport note (if applicable) ⏭️ N/A Not a backport

Commit 2/2: FROMLIST: dt-bindings: display/msm: Document Adreno 830 GPU/GMU

Check Status Note
Subject matches upstream ⏭️ N/A No lore link to compare against
Body preserves rationale ⏭️ N/A No lore link to compare against
Fixes tag present/correct ⏭️ N/A Not applicable (new feature)
Authorship preserved ⏭️ N/A No lore link to compare against
Backport note (if applicable) ⏭️ N/A Not a backport

Diff

Cannot validate diff content without upstream lore source.

Issues

  1. Missing lore.kernel.org links (CRITICAL): Both commits use the FROMLIST: prefix, which according to the kernel commit prefix conventions means "Posted to mailing list, not yet merged" and requires a lore.kernel.org link. Neither commit includes a Link: tag pointing to the upstream posting.

  2. Incomplete integration presence: According to integration_presence_report.md, both commits show only partial presence in qcom-next and topics branches. This means subject or partial tree evidence was found, but the full change was not verified. Expected: commits should be fully present in integration branches before merging to topics.

Verdict

Do not merge. Both commits must include Link: https://lore.kernel.org/r/<message-id> tags pointing to their upstream mailing list postings. The FROMLIST: prefix explicitly indicates these patches were posted to a mailing list and requires attribution to the upstream source.

Final Summary

  1. Lore link present: No — both commits use FROMLIST: prefix but lack required Link: tags
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot verify without lore links
  4. PR present in qcom-next/topics: Partial — 2/2 commits show only partial integration evidence (subject or partial tree match found, but full change not verified)

Recommendation

Add Link: https://lore.kernel.org/r/<message-id> lines to both commit messages pointing to the original mailing list postings, then re-run validation. The FROMLIST: prefix is specifically for patches posted to upstream mailing lists and requires proper attribution.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 21f58ca3b79427e34eafb4c18ff916d8bb95f7ea
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
2/2 [PATCH 2/2] FROMLIST: dt-bindings: display/msm: Document Adreno 830 partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: PARTIAL
present_commits: 0/2
partial_commits: 2/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Partial - 2/2 commit(s) only have partial integration evidence

@qlijarvis

qlijarvis commented Aug 17, 2026

Copy link
Copy Markdown

PR #1701 — checker-log-analyzer

PR: #1701
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32024197573

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 CHECK: line ending with '('
dt-binding-check ❌ KeyError in schema processing (pre-existing tree issue)
dtb-check ⏭️ No DTS changes
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ Missing Link: tags in both commits
tag-check ✅ Both commits have FROMLIST: prefix
qcom-next-check ⚠️ FROMLIST: commits only partially present in qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1701 - Add support for Adreno 830 GPU
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32024197573

Checker Result Summary
checkpatch ❌ 1 CHECK: line ending with '('
dt-binding-check ❌ KeyError in schema processing (pre-existing tree issue)
dtb-check ⏭️ No DTS changes
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ Missing Link: tags in both commits
tag-check ✅ Both commits have FROMLIST: prefix
qcom-next-check ⚠️ FROMLIST: commits only partially present in qcom-next

❌ checkpatch

Root cause: Code style issue - line ending with opening parenthesis

Failure details:

Commit c5d7f6392f78 ("FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU")
CHECK: Lines should not end with a '('
#358: FILE: drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726:
+		.speedbins = ADRENO_SPEEDBINS(

c5d7f6392f78 total: 0 errors, 0 warnings, 1 checks, 370 lines checked

Fix: Move the opening parenthesis to the next line or keep the first argument on the same line:

// Option 1: Move content to same line
.speedbins = ADRENO_SPEEDBINS(0, 1, 2),

// Option 2: If multi-line is needed, keep '(' with content
.speedbins = ADRENO_SPEEDBINS(
		0, 1, 2
),

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git eaa684b68ce5..f1c3bdcb6a80

❌ dt-binding-check

Root cause: Pre-existing tree issue - KeyError in dtschema validator for ti,pruss-intc.yaml schema

Failure details:

KeyError: 'http://devicetree.org/schemas/interrupt-controller/ti,pruss-intc.yaml#'
make[3]: *** [Documentation/devicetree/bindings/Makefile:75: 
    Documentation/devicetree/bindings/processed-schema.json] Error 1

However, the log shows:

dt_binding_check passed for Documentation/devicetree/bindings/display/msm/gmu.yaml...
dtbs_check passed for Documentation/devicetree/bindings/display/msm/gmu.yaml...
dt_binding_check passed for Documentation/devicetree/bindings/display/msm/gpu.yaml...
dtbs_check passed for Documentation/devicetree/bindings/display/msm/gpu.yaml...

Fix: This is a pre-existing tree issue unrelated to this PR. The PR's binding changes (gmu.yaml and gpu.yaml) passed validation successfully. The KeyError occurs during the global schema processing phase and is caused by an issue in the ti,pruss-intc.yaml binding in the tree.

Action: This failure should not block the PR. The PR's binding changes are valid. The tree-wide schema issue needs to be fixed separately.

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/

❌ check-patch-compliance

Root cause: Both commits are missing Link: tags pointing to the upstream lore.kernel.org posting

Failure details:

Checking commit: FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU
No 'Link' found in commit message

Checking commit: FROMLIST: dt-bindings: display/msm: Document Adreno 830 GPU/GMU
No 'Link' found in commit message

Fix: Add Link: tags to both commit messages pointing to the lore.kernel.org URLs where these patches were posted upstream.

For commit 1 (c5d7f63):

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend
# Add to commit body before Signed-off-by:
Link: https://lore.kernel.org/.../<message-id>
git rebase --continue

For commit 2 (a23d76f):

# Same process - add Link: tag

The Link: tag should be placed in the commit body after the description and before the Signed-off-by: trailers.

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base <base_sha> \
  --head <head_sha>

⚠️ qcom-next-check

Status: Both commits have FROMLIST: prefix but are only partially present in qcom-next

Details:
From the integration presence report:

  • Commit 1/2: partial - subject or partial tree evidence found, but full change was not verified
  • Commit 2/2: partial - subject or partial tree evidence found in both qcom-next and topics

Implication: These patches may have been posted upstream (FROMLIST:) and partially integrated into qcom-next, but the full changes don't match exactly. This could indicate:

  1. The patches were modified after posting
  2. Only part of the series was integrated
  3. The patches are still under review upstream

Recommendation: Verify that:

  1. The Link: tags point to the correct upstream posting
  2. The patch content matches what was posted (or document any intentional differences)
  3. The upstream review status is tracked

Verdict

3 blockers to fix before merge:

  1. checkpatch - Fix the line-ending-with-'(' style issue in a6xx_catalog.c:2726
  2. check-patch-compliance - Add Link: tags to both commits pointing to lore.kernel.org
  3. dt-binding-check - This is a pre-existing tree issue and should NOT block this PR

Non-blocking observations:

  • The PR's binding changes (gmu.yaml, gpu.yaml) validated successfully
  • Both commits correctly use FROMLIST: prefix
  • Sparse, UAPI, and DTB checks passed cleanly

Recommended action: Fix items #1 and #2, then re-run CI. The dt-binding-check failure is a tree-wide issue that needs separate investigation.

@qcomlnxci
qcomlnxci requested a review from a team August 18, 2026 11:56
Jie Zhang added 2 commits August 19, 2026 19:01
Jie Zhang @ksanadhy
FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU
d036e8d 
Add support for the Adreno 830 GPU present in SM8750 SoC. Adreno 830 GPU
belongs to the A8x Gen 1 family and it is architecturally close Adreno 840.
Add a new catalog entry along with the register list to enable support
for this GPU.

Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com>
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-1-207ad1fac1c7@oss.qualcomm.com/
Jie Zhang @ksanadhy
FROMLIST: dt-bindings: display/msm: Document Adreno 830 GPU/GMU
40452ec 
Adreno 830 GPU present in SM8750 chipset belongs to the A8x family of
Adreno GPU. It is similar to Adreno 840 GPU with some meaningful
differences like GMEM , register file size etc.

Document Adreno 830 GPU and GMU present in the SM8750 chipset.

Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com>
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-2-207ad1fac1c7@oss.qualcomm.com/
@Komal-Bajaj
Komal Bajaj (Komal-Bajaj) merged commit 2452d5e into qualcomm-linux:tech/mm/gpu Aug 21, 2026
6 of 8 checks passed
@qlijarvis

qlijarvis commented Aug 21, 2026

Copy link
Copy Markdown

PR #1701 — validate-patch

PR: #1701

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: Yes — both commits link to their respective lore.kernel.org patches from the 6-patch "drm/msm: Support for Adreno 830 GPU" series (v1, posted 2026-08-09)

  2. Lore link matches PR commits: Yes — diff content is faithful to lore patches 1/6 and 2/6. The only difference is a context-only delta in gpu.yaml where the PR's base tree lacks qcom,adreno-44050a01 (which exists in the lore patch's base tree). The actual change (adding qcom,adreno-44050001) is identical in both versions.

  3. Upstream patch status: ✅ ACKed — both patches have received formal Reviewed-by: tags from three subsystem maintainers (Krzysztof Kozlowski, Dmitry Baryshkov, Konrad Dybcio). No merge/queued confirmation yet, but strong positive review signals indicate likely acceptance. Last activity: 2026-08-09 (patch posting date).

  4. PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1701 - drm/msm: Support for Adreno 830 GPU (patches 1-2 of upstream 6-patch series)
Upstream commits:

Commit Message

Check Status Note
Subject matches upstream ✅ Both commits: subject identical except for FROMLIST: prefix (correct for pending patches)
Body preserves rationale ✅ Both commits: body text matches lore patches verbatim
Fixes tag present/correct N/A No Fixes tags in upstream patches
Authorship preserved ✅ Both commits: From: Jie Zhang <jie.zhang@oss.qualcomm.com> matches lore author; original author's Signed-off-by present; submitter (Kaushal Sanadhya) added own Signed-off-by (correct for FROMLIST:)
Backport note (if applicable) N/A FROMLIST: patches don't require backport notes

Diff

File Status Notes
drivers/gpu/drm/msm/adreno/a6xx_catalog.c ✅ Identical to lore patch 1/6
drivers/gpu/drm/msm/adreno/a8xx_gpu.c ✅ Identical to lore patch 1/6
drivers/gpu/drm/msm/adreno/adreno_gpu.h ✅ Identical to lore patch 1/6
Documentation/devicetree/bindings/display/msm/gmu.yaml ✅ Identical to lore patch 2/6
Documentation/devicetree/bindings/display/msm/gpu.yaml ✅ Context-only delta: PR based on tree without qcom,adreno-44050a01; lore based on tree with it. Actual change (adding qcom,adreno-44050001) is identical

Upstream Patch Status

Commit Community Verdict
[PATCH 1/6] drm/msm/a8xx: Add support for Adreno 830 GPU ✅ ACKed — Reviewed-by: Krzysztof Kozlowski, Dmitry Baryshkov, Konrad Dybcio
[PATCH 2/6] dt-bindings: display/msm: Document Adreno 830 GPU/GMU ✅ ACKed — Reviewed-by: Krzysztof Kozlowski, Dmitry Baryshkov, Konrad Dybcio

Integration Presence (qcom-next/topics)

Commit Status
[PATCH 1/2] FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU ✅ Present in topics as 344d1eb
[PATCH 2/2] FROMLIST: dt-bindings: display/msm: Document Adreno 830 ✅ Present in topics as 2452d5e

Verdict

Merge as-is. Both commits faithfully represent the upstream lore patches (1/6 and 2/6 from the 6-patch series). The patches have received formal Reviewed-by tags from subsystem maintainers (Krzysztof Kozlowski, Dmitry Baryshkov, Konrad Dybcio), indicating strong community acceptance. The FROMLIST: prefix is correct since the patches are posted to the mailing list but not yet merged into mainline. Authorship is correctly preserved with the original author in From: and Signed-off-by:, and the submitter appropriately added their own Signed-off-by: trailer. The minor context difference in gpu.yaml (presence/absence of qcom,adreno-44050a01 in context lines) is due to different base tree versions and does not affect the actual change being made.

Final Summary

  1. Lore link present: Yes — both commits link to their respective lore.kernel.org patches from the 6-patch "drm/msm: Support for Adreno 830 GPU" series (v1, posted 2026-08-09)

  2. Lore link matches PR commits: Yes — diff content is faithful to lore patches 1/6 and 2/6. The only difference is a context-only delta in gpu.yaml where the PR's base tree lacks qcom,adreno-44050a01 (which exists in the lore patch's base tree). The actual change (adding qcom,adreno-44050001) is identical in both versions.

  3. Upstream patch status: ✅ ACKed — both patches have received formal Reviewed-by: tags from three subsystem maintainers (Krzysztof Kozlowski, Dmitry Baryshkov, Konrad Dybcio). No merge/queued confirmation yet, but strong positive review signals indicate likely acceptance. Last activity: 2026-08-09 (patch posting date).

  4. PR present in qcom-next/topics: Yes — both commits are present in the topics branch with exact patch-id matches (commit 1: 344d1eb, commit 2: 2452d5e)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 344d1eb present
2/2 [PATCH 2/2] FROMLIST: dt-bindings: display/msm: Document Adreno 830 partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 2452d5e present

Final Status

overall_status: PASS
present_commits: 2/2
partial_commits: 0/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics

@qlijarvis

qlijarvis commented Aug 21, 2026

Copy link
Copy Markdown

PR #1701 — checker-log-analyzer

PR: #1701
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32134234112

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 CHECK warning on line ending with (
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ Content mismatch on both commits
tag-check ✅ Both commits have valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

Let me output the report directly:

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1701 - Add support for Adreno 830 GPU
Target Branch: tech/mm/gpu (kernel-topics)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32134234112

Checker Result Summary
checkpatch ❌ 1 CHECK warning on line ending with (
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ Content mismatch on both commits
tag-check ✅ Both commits have valid FROMLIST: prefix

❌ checkpatch

Root cause: Line ending with opening parenthesis ( in speedbins initialization.

Failure details:

Commit ef1490ad1184 ("FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU")
CHECK: Lines should not end with a '('
#359: FILE: drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726:
+		.speedbins = ADRENO_SPEEDBINS(

Fix: Move the opening parenthesis to the next line or keep the first argument on the same line:

git rebase -i <base_sha>   # mark commit ef1490ad1184 as 'edit'
# Edit drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726
# Change from:
#   .speedbins = ADRENO_SPEEDBINS(
# To:
#   .speedbins = ADRENO_SPEEDBINS(
#       <first-argument>, ...
# or:
#   .speedbins =
#       ADRENO_SPEEDBINS(<first-argument>, ...
git add drivers/gpu/drm/msm/adreno/a6xx_catalog.c
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git cf91f5e1b462..b713a7f75979

❌ check-patch-compliance

Root cause: Both commits show "Change is different from the one mentioned in Link" — the PR patches differ from the upstream lore patches.

Failure details:

Checking commit: FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU
Change is different from the one mentioned in Link

Checking commit: FROMLIST: dt-bindings: display/msm: Document Adreno 830 GPU/GMU
Change is different from the one mentioned in Link

Analysis:

This failure indicates that the patches in the PR do not exactly match the upstream patches posted to lore.kernel.org. This can happen for several reasons:

  1. Context-only differences — The PR is based on a different kernel version/tree than the upstream patch, causing line number shifts in the diff context. This is often a false positive.
  2. Legitimate adaptations — The patch was modified to fit the target tree (e.g., resolving conflicts, adapting to local changes).
  3. Missing or extra hunks — The PR patch is missing changes from upstream, or includes additional changes not in the upstream patch.

Fix:

Fetch the upstream patches and compare:

# Fetch both upstream patches
b4 am --single-message -C -l -3 https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-1-207ad1fac1c7@oss.qualcomm.com/ -o /tmp/patch1
b4 am --single-message -C -l -3 https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-2-207ad1fac1c7@oss.qualcomm.com/ -o /tmp/patch2

# Compare the actual code changes (ignoring context):
git format-patch -1 ef1490ad1184 --stdout | awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]' > /tmp/pr_patch1.diff
awk '/^diff/,/^--$/' /tmp/patch1/*.mbx | grep -E '^[+-][^+-]' > /tmp/upstream_patch1.diff
diff /tmp/pr_patch1.diff /tmp/upstream_patch1.diff

# Repeat for second commit
git format-patch -1 6d80cc861c2c --stdout | awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]' > /tmp/pr_patch2.diff
awk '/^diff/,/^--$/' /tmp/patch2/*.mbx | grep -E '^[+-][^+-]' > /tmp/upstream_patch2.diff
diff /tmp/pr_patch2.diff /tmp/upstream_patch2.diff

Possible outcomes:

  • Context-only shift → No action needed; this is a false positive due to different base trees.
  • Legitimate adaptation → Document the changes in the commit message (e.g., "Adapted for tech/mm/gpu tree: ...").
  • Missing hunk → Add the missing changes from upstream.
  • Extra hunk → Remove or attribute separately if it's an unrelated fix.

Note: Since this PR targets the tech/mm/gpu topic branch (not qcom-next or qcom-next-staging), it's common for patches to be adapted to the topic tree's baseline. If the differences are only context shifts or minor adaptations, this is acceptable. However, if there are substantive code differences, they should be documented or corrected.

Verdict

2 blockers to fix before merge:

  1. checkpatch — Fix the line-ending-with-( style issue in drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726.
  2. check-patch-compliance — Investigate and document the content differences between the PR patches and the upstream lore patches. If the differences are only context shifts, no code change is needed, but the checker will continue to flag this as a known limitation for topic-branch PRs.

Note: The check-patch-compliance failure may be a false positive if the differences are only due to context shifts from the topic branch baseline. However, it's important to verify that no substantive code changes were introduced or omitted compared to the upstream patches.

[/CHECKER_LOG_REPORT]

@qlijarvis

qlijarvis commented Aug 22, 2026

Copy link
Copy Markdown

PR #1701 — validate-patch

PR: #1701

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: Yes — both patches include correct lore.kernel.org links in Link: trailer
  2. Lore link matches PR commits: Yes — diff content and commit messages are identical to lore patches (part of 6-patch series "drm/msm: Support for Adreno 830 GPU")
  3. Upstream patch status: ⏳ In review — patches have Reviewed-by tags from Krzysztof Kozlowski, Dmitry Baryshkov, and Konrad Dybcio; not yet merged to mainline
  4. PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1701 - "drm/msm: Support for Adreno 830 GPU"
Upstream commits:

Commit Message

Check Status Note
Subject matches upstream ✅ Both patches: subject faithfully preserved with FROMLIST: prefix added
Body preserves rationale ✅ Commit message body identical to lore patches
Fixes tag present/correct N/A No Fixes tag in upstream patches
Authorship preserved ✅ From: correctly shows Jie Zhang (original author); lore author's Signed-off-by present
Backport note (if applicable) N/A FROMLIST commits do not require backport notes

Diff

File Status Notes
drivers/gpu/drm/msm/adreno/a6xx_catalog.c ✅ Patch 1: diff content matches lore patch exactly
drivers/gpu/drm/msm/adreno/a8xx_gpu.c ✅ Patch 1: diff content matches lore patch exactly
drivers/gpu/drm/msm/adreno/adreno_gpu.h ✅ Patch 1: diff content matches lore patch exactly
Documentation/devicetree/bindings/display/msm/gmu.yaml ✅ Patch 2: diff content matches lore patch exactly
Documentation/devicetree/bindings/display/msm/gpu.yaml ✅ Patch 2: diff content matches lore patch exactly

Verdict

Merge as-is. Both patches faithfully represent their upstream lore sources with correct FROMLIST prefix, preserved authorship, and appropriate submitter Signed-off-by trailer.

Final Summary

  1. Lore link present: Yes — both patches include correct lore.kernel.org links in Link: trailer
  2. Lore link matches PR commits: Yes — diff content and commit messages are identical to lore patches (part of 6-patch series "drm/msm: Support for Adreno 830 GPU")
  3. Upstream patch status: ⏳ In review — patches have Reviewed-by tags from Krzysztof Kozlowski, Dmitry Baryshkov, and Konrad Dybcio; not yet merged to mainline
  4. PR present in qcom-next/topics: Yes — both commits present in topics branch (patch 1: 344d1eb, patch 2: 2452d5e)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 344d1eb present
2/2 [PATCH 2/2] FROMLIST: dt-bindings: display/msm: Document Adreno 830 partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 2452d5e present

Final Status

overall_status: PASS
present_commits: 2/2
partial_commits: 0/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics

@qlijarvis

qlijarvis commented Aug 22, 2026

Copy link
Copy Markdown

PR #1701 — checker-log-analyzer

PR: #1701
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32254307466

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 CHECK (style)
dt-binding-check ✅ —
dtb-check ⏭️ No DTS changes
sparse-check ✅ —
check-uapi-headers ✅ —
check-patch-compliance ❌ Content mismatch on both commits
tag-check ✅ Both commits have FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

Let me output the report directly:

🤖 CI Checker Analysis (checker-log-analyzer)

PR: [#1701] Add Adreno 830 GPU support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32254307466
Target branch: tech/mm/gpu (kernel-topics)

Checker Result Summary
checkpatch ⚠️ 1 CHECK (style)
dt-binding-check ✅ —
dtb-check ⏭️ No DTS changes
sparse-check ✅ —
check-uapi-headers ✅ —
check-patch-compliance ❌ Content mismatch on both commits
tag-check ✅ Both commits have FROMLIST: prefix

⚠️ checkpatch

Root cause: Minor style issue — line ending with opening parenthesis in drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726.

Failure details:

Commit 6d07ed7f5e2c ("FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU")
CHECK: Lines should not end with a '('
#360: FILE: drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726:
+		.speedbins = ADRENO_SPEEDBINS(

total: 0 errors, 0 warnings, 1 checks, 370 lines checked

This is a CHECK (not ERROR or WARNING), meaning it's a style suggestion rather than a blocker. The line .speedbins = ADRENO_SPEEDBINS( ends with an opening parenthesis, which checkpatch flags as non-idiomatic kernel style.

Fix:

git rebase -i <base_sha>   # mark commit 6d07ed7f5e2c as 'edit'
# Edit drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726
# Move the opening '(' to the next line or reformat the macro invocation
git add drivers/gpu/drm/msm/adreno/a6xx_catalog.c
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES \
  --git 93170cbe35ae..74d73e6a8afd

❌ check-patch-compliance

Root cause: Both commits have content differences compared to their upstream lore.kernel.org links.

Failure details:

Checking commit: FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU
Change is different from the one mentioned in Link
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-1-207ad1fac1c7@oss.qualcomm.com/

Checking commit: FROMLIST: dt-bindings: display/msm: Document Adreno 830 GPU/GMU
Change is different from the one mentioned in Link
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-2-207ad1fac1c7@oss.qualcomm.com/

The checker fetched the upstream patches from lore and found that the +/- diff lines do not match exactly. This can happen for several reasons:

  1. Context-only shift — surrounding code changed, but the actual patch content is identical (false positive).
  2. Legitimate adaptation — the patch was modified to fit the target tree (e.g., resolved conflicts, adapted to different baseline).
  3. Missing or extra hunks — some changes were added or removed compared to upstream.

Analysis steps:

To determine which case applies, fetch the upstream patches and compare:

# Fetch upstream patch 1
b4 am --single-message -C -l -3 \
  https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-1-207ad1fac1c7@oss.qualcomm.com/ \
  -o /tmp/upstream1

# Fetch upstream patch 2
b4 am --single-message -C -l -3 \
  https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-2-207ad1fac1c7@oss.qualcomm.com/ \
  -o /tmp/upstream2

# Compare the actual diff lines (ignoring context)
git format-patch -1 6d07ed7f5e2c --stdout | \
  awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]' > /tmp/pr_patch1.diff

awk '/^diff/,/^--$/' /tmp/upstream1/*.mbx | \
  grep -E '^[+-][^+-]' > /tmp/upstream_patch1.diff

diff /tmp/pr_patch1.diff /tmp/upstream_patch1.diff

# Repeat for patch 2
git format-patch -1 b89e43648c15 --stdout | \
  awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]' > /tmp/pr_patch2.diff

awk '/^diff/,/^--$/' /tmp/upstream2/*.mbx | \
  grep -E '^[+-][^+-]' > /tmp/upstream_patch2.diff

diff /tmp/pr_patch2.diff /tmp/upstream_patch2.diff

Possible outcomes:

  • If diffs are identical or differ only in context lines: This is a false positive due to baseline differences. Document the adaptation in the commit message (e.g., "Adapted to tech/mm/gpu baseline") and note that the functional change matches upstream.

  • If there are extra hunks in the PR: These may be necessary adaptations for the target tree. Document them explicitly in the commit message, e.g.:

    [ Adapted for tech/mm/gpu: added missing include for <header.h> ]

  • If there are missing hunks from upstream: Add them back, or document why they were intentionally omitted.

Fix:

If the differences are legitimate adaptations:

git rebase -i <base_sha>   # mark commits as 'reword'
# Add a note in the commit body explaining the adaptation:
# [ Adapted for tech/mm/gpu: <reason> ]
git rebase --continue

If the differences are unintentional:

# Re-apply the upstream patch cleanly
b4 am -o - <link> | git am -3
# Or manually fix the discrepancies
git rebase -i <base_sha>   # mark as 'edit', fix, amend, continue

Note: The check-patch-compliance checker is strict about content matching. Even minor adaptations (e.g., resolving conflicts, adjusting to a different baseline) will trigger this failure. The key is to document any intentional changes in the commit message so reviewers understand the delta.

Verdict

2 issues to address before merge:

  1. checkpatch CHECK (minor): Line ending with ( in a6xx_catalog.c:2726 — fix by reformatting the macro invocation.

  2. check-patch-compliance content mismatch (blocker): Both commits differ from their upstream lore links. Investigate the differences using the analysis steps above:

    • If the changes are legitimate adaptations → document them in the commit message.
    • If the changes are unintentional → re-apply the upstream patches cleanly.

All other checkers passed:

  • ✅ dt-binding-check — binding YAML validated successfully
  • ✅ sparse-check — no static analysis warnings
  • ✅ check-uapi-headers — no ABI changes
  • ✅ tag-check — both commits have the required FROMLIST: prefix for the tech/mm/gpu branch
  • ⏭️ dtb-check — skipped (no DTS changes)

[/CHECKER_LOG_REPORT]

@qlijarvis

qlijarvis commented Aug 22, 2026

Copy link
Copy Markdown

PR #1701 — validate-patch

PR: #1701

Verdict Issues Detailed Report
⚠️ 3 Full report

Final Summary

  1. Lore link present: Yes — both patches link to https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-{1,2}-207ad1fac1c7@oss.qualcomm.com/
  2. Lore link matches PR commits: Yes — diff content faithful to lore patches 1/6 and 2/6; context differences are due to tree state (missing qcom,adreno-44050a01 in PR tree); submitter's Signed-off-by added per FROMLIST workflow
  3. Upstream patch status: ⏳ Decision Pending — posted Aug 9, 2026; received Reviewed-by from Krzysztof Kozlowski, Dmitry Baryshkov, and Konrad Dybcio (Aug 13, 2026); not yet merged into maintainer tree or mainline (as of Aug 22, 2026)
  4. PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1701 - FROMLIST: drm/msm: Support for Adreno 830 GPU
Upstream commit: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-0-207ad1fac1c7@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Patch 1: ✅ matches; Patch 2: ⚠️ truncated ("Document Adreno 830" vs "Document Adreno 830 GPU/GMU")
Body preserves rationale ✅ Both patches preserve full commit message body
Fixes tag present/correct N/A No Fixes tags in upstream patches
Authorship preserved ✅ Both patches: From: Jie Zhang matches lore; FROMLIST prefix allows submitter to differ
Backport note (if applicable) N/A FROMLIST prefix used correctly for patches under review

Diff

File Status Notes
drivers/gpu/drm/msm/adreno/a6xx_catalog.c ✅ Identical to lore patch 1/6
drivers/gpu/drm/msm/adreno/a8xx_gpu.c ✅ Identical to lore patch 1/6
drivers/gpu/drm/msm/adreno/adreno_gpu.h ✅ Identical to lore patch 1/6
Documentation/devicetree/bindings/display/msm/gmu.yaml ✅ Identical to lore patch 2/6
Documentation/devicetree/bindings/display/msm/gpu.yaml ⚠️ Context-only difference: PR tree missing qcom,adreno-44050a01 line; actual changes identical

Issues

  • Patch 2 subject truncated: PR subject is "Document Adreno 830" but lore subject is "Document Adreno 830 GPU/GMU" — minor truncation, semantically equivalent
  • Extra Signed-off-by: Both PR patches add Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com> not present in lore — this is acceptable as the submitter's sign-off for cherry-picking the FROMLIST patch
  • Context difference in gpu.yaml: PR tree is missing qcom,adreno-44050a01 line that exists in lore patch context — this is a legitimate tree-state difference; the actual change (adding qcom,adreno-44050001) is identical

Verdict

Merge as-is. The patches faithfully represent the lore upstream with only minor, acceptable adaptations: (1) submitter's Signed-off-by added per FROMLIST workflow, (2) context lines differ due to tree state, (3) patch 2 subject slightly truncated but semantically equivalent. All code changes are identical to upstream.

Final Summary

  1. Lore link present: Yes — both patches link to https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-{1,2}-207ad1fac1c7@oss.qualcomm.com/
  2. Lore link matches PR commits: Yes — diff content faithful to lore patches 1/6 and 2/6; context differences are due to tree state (missing qcom,adreno-44050a01 in PR tree); submitter's Signed-off-by added per FROMLIST workflow
  3. Upstream patch status: ⏳ Decision Pending — posted Aug 9, 2026; received Reviewed-by from Krzysztof Kozlowski, Dmitry Baryshkov, and Konrad Dybcio (Aug 13, 2026); not yet merged into maintainer tree or mainline (as of Aug 22, 2026)
  4. PR present in qcom-next/topics: Yes — commit 1/2 present at 344d1eb, commit 2/2 present at 2452d5e in topics branch

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 344d1eb present
2/2 [PATCH 2/2] FROMLIST: dt-bindings: display/msm: Document Adreno 830 partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 2452d5e present

Final Status

overall_status: PASS
present_commits: 2/2
partial_commits: 0/2
missing_commits: 0/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Yes - all 2 commit(s) are present in qcom-next or topics

@qlijarvis

qlijarvis commented Aug 22, 2026

Copy link
Copy Markdown

PR #1701 — checker-log-analyzer

PR: #1701
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32259333778

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 CHECK issue: line ending with '('
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ✅ Passed
tag-check N/A Skipped (target branch is qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1701 - Add support for Adreno 830 GPU
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32259333778
Target branch: qcom-next

Checker Result Summary
checkpatch ❌ 1 CHECK issue: line ending with '('
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ✅ Passed
tag-check N/A Skipped (target branch is qcom-next)

❌ checkpatch

Root cause: Commit d036e8d has a macro invocation split across lines with the opening parenthesis at the end of the first line, violating kernel coding style preference.

Failure details:

Commit d036e8ddb04d ("FROMLIST: drm/msm/a8xx: Add support for Adreno 830 GPU")
CHECK: Lines should not end with a '('
#360: FILE: drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726:
+		.speedbins = ADRENO_SPEEDBINS(

d036e8ddb04d total: 0 errors, 0 warnings, 1 checks, 369 lines checked

Context from patch:

.preempt_record_size = 13536 * SZ_1K,
.speedbins = ADRENO_SPEEDBINS(
	{ 0,   0 },
	{ 252, 0 },
	{ 242, 1 },
	...

Fix: Move the opening parenthesis to the next line or keep the first argument on the same line as the macro name:

Option 1 (preferred for multi-line macro arguments):

.speedbins = ADRENO_SPEEDBINS({ 0,   0 },
	{ 252, 0 },
	{ 242, 1 },
	...

Option 2 (if macro definition allows):

.speedbins =
	ADRENO_SPEEDBINS({ 0,   0 },
		{ 252, 0 },
		{ 242, 1 },
		...

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 932363d442bf..3772c8e52477

Fix command:

git rebase -i 932363d442bf   # mark commit d036e8ddb04d as 'edit'
# Edit drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726
# Apply one of the formatting options above
git add drivers/gpu/drm/msm/adreno/a6xx_catalog.c
git commit --amend --no-edit
git rebase --continue

Verdict

1 minor style issue to fix before merge.

This is a CHECK-level issue (not an ERROR or WARNING), which means it's a style preference rather than a hard blocker. However, it's trivial to fix and should be addressed to maintain consistency with kernel coding style.

All other checkers passed cleanly:

  • ✅ DT binding validation passed for both GPU and GMU bindings
  • ✅ Sparse static analysis found no issues
  • ✅ UAPI headers unchanged
  • ✅ Patch compliance verified (both commits have proper FROMLIST: prefix and valid Link: tags)

Recommendation: Fix the checkpatch style issue by adjusting the line break at drivers/gpu/drm/msm/adreno/a6xx_catalog.c:2726, then the PR will be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Komal-Bajaj Komal Bajaj (Komal-Bajaj) Komal-Bajaj approved these changes
@quic-rajeshk Rajesh Kemisetti (quic-rajeshk) Awaiting requested review from quic-rajeshk quic-rajeshk was automatically assigned from qualcomm-linux/kernel-tech-mm-gpu-maint

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quic-ksanadhy @qlijarvis @Komal-Bajaj