Skip to content

arm64: dts: qcom: sm8750: Add Adreno 830 GPU support - #1717

Merged
Shiraz Hashim (shashim-quic) merged 5 commits into
qualcomm-linux:tech/all/dt/pakalafrom
quic-ksanadhy:pr/pakala-gpu-top5
Aug 24, 2026
Merged

arm64: dts: qcom: sm8750: Add Adreno 830 GPU support#1717
Shiraz Hashim (shashim-quic) merged 5 commits into
qualcomm-linux:tech/all/dt/pakalafrom
quic-ksanadhy:pr/pakala-gpu-top5

Conversation

@quic-ksanadhy

@quic-ksanadhy quic-ksanadhy commented Aug 19, 2026

Copy link
Copy Markdown

Changes

  1. Add GPU clock & IOMMU nodes — Adds GPU_CC and GX_CC clock controller nodes required to power up graphics hardware, along with the associated IOMMU.

  2. Add GPU and GMU nodes — Describes the Adreno 830 GPU and GMU nodes in the SM8750 devicetree. Adds qfprom node for GPU speedbin fuse register. A830 belongs to the A8x family, similar to A840 with differences in GMEM size and register file size.

  3. Add GPU cooling — Sets up GPU thermal cooling by throttling GPU speed when temperature reaches 105°C, since the GPU does not throttle automatically unlike the CPU.

  4. sm8750-mtp: Enable Adreno 830 GPU — Enables GPU on the SM8750 MTP platform and provides path for the zap shader.

  5. sm8750-qrd: Enable Adreno 830 GPU — Enables GPU on the SM8750 QRD platform and provides path for the zap shader.

Links

CRs-Fixed: 4647429

quic-kdybcio and others added 5 commits August 19, 2026 18:36
Add the GPU_CC and GX_CC (brand new! as far as we're concerned, this
is simply a separate block housing the GX GDSC) nodes, required to
power up the graphics-related hardware.

Make use of it by enabling the associated IOMMU as well. The GPU itself
needs some more work and will be enabled later.

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Co-developed-by: Taniya Das <taniya.das@oss.qualcomm.com>
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260714-gpucc_dt_v6-v6-1-16bf5289572d@oss.qualcomm.com/
Adreno 830 GPU present in SM8750 chipset belongs to the A8x family of
Adreno GPU. It is similar to Adreno 840 GPU with some meaningful
differences like GMEM size, register file size etc.

Describe A830 GPU and GMU nodes in SM8750 devicetree. Also, add the
qfprom node to describe the GPU speedbin fuse register.

Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com>
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-3-207ad1fac1c7@oss.qualcomm.com/
Unlike the CPU, the GPU does not throttle its speed automatically
when it reaches high temperatures.

Set up GPU cooling by throttling the GPU speed
when reaching 105°C.

Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-4-207ad1fac1c7@oss.qualcomm.com/
Enable GPU for sm8750-mtp platform and provide path for zap
shader.
Upstream-Status: Pending
Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com>
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-5-207ad1fac1c7@oss.qualcomm.com/
Enable GPU for sm8750-qrd platform and provide path for zap
shader.

Signed-off-by: Jie Zhang <jie.zhang@oss.qualcomm.com>
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Signed-off-by: Kaushal Sanadhya <ksanadhy@qti.qualcomm.com>
Link: https://lore.kernel.org/lkml/20260809-pakala-gpu-v1-6-207ad1fac1c7@oss.qualcomm.com/
@qcomlnxci
qcomlnxci requested review from a team, knaveen-qc, Rajendra (rrnayak) and Trilok Soni (trsoni) and removed request for a team August 19, 2026 13:14
@puranamtejaswi

Copy link
Copy Markdown

LGTM

@qlijarvis

Copy link
Copy Markdown

PR #1717 — validate-patch

PR: #1717

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: Yes — all 5 commits have valid lore.kernel.org links in Link: trailers
  2. Lore link matches PR commits: Yes — commit messages, authorship, and diff content (spot-checked) are faithful to lore sources. FROMLIST prefix correctly applied. Original authors preserved in From: field, and their Signed-off-by present in all commits.
  3. Upstream patch status: ⏳ In review — Reviewed-by from Konrad Dybcio found for at least patch 3/6 (PR commit 2/5). No merge or NAK signals found. Patches posted in July-August 2026, still under community review.
  4. PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1717 - "arm64: dts: qcom: sm8750: Add GPU support"
Upstream commits: 5 patches from 2 lore series
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream All 5 commits have subjects matching lore patches (with FROMLIST: prefix added)
Body preserves rationale Commit message bodies are faithful to lore patches
Fixes tag present/correct N/A No Fixes tags in these patches (new feature addition)
Authorship preserved All commits correctly preserve original lore author in From: field
Backport note (if applicable) N/A FROMLIST commits, not backports
Co-developed-by used correctly Commit 1/5 uses Co-developed-by correctly for Taniya Das

Diff

File Status Notes
arch/arm64/boot/dts/qcom/sm8750.dtsi (1/5) GPU clock controller and IOMMU nodes match lore patch exactly
arch/arm64/boot/dts/qcom/sm8750.dtsi (2/5) GPU and GMU nodes match lore patch (spot-checked)
arch/arm64/boot/dts/qcom/sm8750.dtsi (3/5) GPU cooling changes (not fully verified but authorship/message correct)
arch/arm64/boot/dts/qcom/sm8750-mtp.dtsi (4/5) Enable Adreno 830 on MTP (not fully verified but authorship/message correct)
arch/arm64/boot/dts/qcom/sm8750-qrd.dtsi (5/5) Enable Adreno 830 on QRD (not fully verified but authorship/message correct)

Issues

  • Integration presence concern: According to integration_presence_report.md, 4/5 commits show "partial" presence in qcom-next (subject or partial tree evidence found, but full change not verified), and 1/5 commit (3/5 - GPU cooling) is completely "missing" from both qcom-next and topics. This suggests these patches may not have landed in the integration branch yet, or the content differs slightly from what's in qcom-next.

Verdict

Merge with caution. All commits are faithful to their lore sources with correct authorship, commit messages, and FROMLIST prefixes. However, the integration presence check shows that most commits are only partially present or missing from qcom-next/topics, which may indicate:

  1. These patches are very recent and haven't been integrated yet, or
  2. There are minor differences between the PR content and what's in qcom-next

Recommend verifying why commit 3/5 (GPU cooling) is completely missing from qcom-next before merging.

Final Summary

  1. Lore link present: Yes — all 5 commits have valid lore.kernel.org links in Link: trailers
  2. Lore link matches PR commits: Yes — commit messages, authorship, and diff content (spot-checked) are faithful to lore sources. FROMLIST prefix correctly applied. Original authors preserved in From: field, and their Signed-off-by present in all commits.
  3. Upstream patch status: ⏳ In review — Reviewed-by from Konrad Dybcio found for at least patch 3/6 (PR commit 2/5). No merge or NAK signals found. Patches posted in July-August 2026, still under community review.
  4. PR present in qcom-next/topics: ❌ Fail — 1/5 commit (GPU cooling) is missing from both qcom-next and topics; 4/5 commits show only "partial" presence (subject or partial tree evidence found, but full change not verified). Overall status: FAIL per integration_presence_report.md.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/5 [PATCH 1/5] FROMLIST: arm64: dts: qcom: sm8750: Add GPU clock & IOMMU partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
2/5 [PATCH 2/5] FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
3/5 [PATCH 3/5] FROMLIST: arm64: dts: qcom: sm8750: Add GPU cooling missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
4/5 [PATCH 4/5] FROMLIST: arm64: dts: qcom: sm8750-mtp: Enable Adreno 830 partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
5/5 [PATCH 5/5] FROMLIST: arm64: dts: qcom: sm8750-qrd: Enable Adreno 830 partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: FAIL
present_commits: 0/5
partial_commits: 4/5
missing_commits: 1/5
topics_checked_for_commits: 5/5
final_summary: PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1717 — checker-log-analyzer

PR: #1717
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/32256999501

Checker Result Summary
Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Passed
sparse-check ⏭️ Skipped (no C/H file changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Passed (all commits have valid FROMLIST: prefix and Link: tags)
tag-check Passed (all commits have FROMLIST: prefix)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1717 - Add Adreno 830 GPU support for SM8750
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/32256999501
Target branch: tech/all/dt/pakala (kernel-topics)

Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Passed
sparse-check ⏭️ Skipped (no C/H file changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Passed (all commits have valid FROMLIST: prefix and Link: tags)
tag-check Passed (all commits have FROMLIST: prefix)

❌ checkpatch

Root cause: Two DT compatible strings are not documented in devicetree bindings.

Failure details:

Commit f1b476dcfa68 ("FROMLIST: arm64: dts: qcom: sm8750: Add GPU and GMU nodes")

WARNING: DT compatible string "qcom,adreno-44050001" appears un-documented -- check ./Documentation/devicetree/bindings/
#30: FILE: arch/arm64/boot/dts/qcom/sm8750.dtsi:2164:
+			compatible = "qcom,adreno-44050001", "qcom,adreno";

WARNING: DT compatible string "qcom,adreno-gmu-830.1" appears un-documented -- check ./Documentation/devicetree/bindings/
#207: FILE: arch/arm64/boot/dts/qcom/sm8750.dtsi:2345:
+			compatible = "qcom,adreno-gmu-830.1", "qcom,adreno-gmu";

f1b476dcfa6851d9c53ac769d15c6305dd798bac total: 0 errors, 2 warnings, 0 checks, 249 lines checked

Analysis:

This PR introduces two new Adreno 830 GPU compatible strings:

  • qcom,adreno-44050001 (GPU device)
  • qcom,adreno-gmu-830.1 (GMU - Graphics Management Unit)

These compatible strings are not yet documented in the kernel's devicetree binding documentation. This is a documentation gap, not a functional issue.

Fix:

The compatible strings need to be added to the appropriate DT binding YAML files:

  1. For qcom,adreno-44050001:

    • Add to Documentation/devicetree/bindings/display/msm/gpu.yaml (or the appropriate Adreno GPU binding file)
    • Add an enum entry under the compatible property
  2. For qcom,adreno-gmu-830.1:

    • Add to Documentation/devicetree/bindings/display/msm/gmu.yaml (or the appropriate GMU binding file)
    • Add an enum entry under the compatible property

Example fix pattern:

properties:
  compatible:
    items:
      - enum:
          - qcom,adreno-44050001  # Add this line
          - qcom,adreno-gmu-830.1  # Add this line
          # ... existing entries

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 21f58ca3b794..842925fb1509

Note: These warnings are non-blocking for a FROMLIST patch series. If the upstream patch series on lore.kernel.org does not yet include the binding documentation updates, it's acceptable to merge this PR as-is and track the binding updates separately when they land upstream. However, if the binding documentation exists upstream, it should be included in this PR.


Verdict

2 non-blocking warnings to address:

  1. Document qcom,adreno-44050001 in the Adreno GPU binding YAML
  2. Document qcom,adreno-gmu-830.1 in the GMU binding YAML

Recommendation:

Ready to merge with caveats — All functional checks passed. The checkpatch warnings are documentation-only issues.

Action items:

  • Verify if the upstream patch series includes binding documentation updates
  • If upstream has the binding docs, add them to this PR
  • If upstream doesn't have them yet, merge as-is and track binding updates separately

All commits properly use the FROMLIST: prefix and include Link: tags pointing to lore.kernel.org, indicating these patches are posted upstream and awaiting review/merge.

@shashim-quic
Shiraz Hashim (shashim-quic) merged commit 0aca0eb into qualcomm-linux:tech/all/dt/pakala Aug 24, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants