Validate MyETM's scenario_access grant behind a flag - #1797
Draft
louispt1 wants to merge 1 commit into
Draft
Conversation
…existing scenario_users check for access
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
ETEngine determines scenario access based on
scenario_users, which is somewhat duplicated between myetm and etengine. The purpose of these changes is to allow etengine to determine the access grant for scenarios (sessions) based on the identity token rather than the scenario users table.The changes are 'off' by default, gated behind a settings flag. The purpose of that was to allow the change to be reversible and test turning it on/off.
Implemented changes
Api::ScenarioGrant.from_tokenbuilds a grant from the decoded identity token, or nil when the claim is absent or malformed.Api::TokenAbilityfolds the grant into its existing rulesSettings.scenario_access_grantsdetermines if the grant claim method is 'on' or 'off' (true/false)I tested this in practice with ETLauncher and it worked well.
Related
This MyETM PR issues the access grant
Checklist