fix(settings): make Codex auth cleanup opt-in - #464
Open
MDX-Tom wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
审查结论:实现完成,建议进入 review。 这次改动的方向是把
当前本地验证:
行为回归覆盖:
完整 service lib 串行验证结果为 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(settings): 让 requires_openai_auth 清理变为可选功能
摘要
当前网关 profile 同步会自动从
config.toml的cmprovider 中删除requires_openai_auth。部分用户依赖该配置,因此本 PR 将清理行为交给应用设置控制,并将默认值设为关闭。修改内容
app_settings_get/app_settings_set持久化,默认值为false;requires_openai_auth值;行为确认
requires_openai_auth = true会继续保留;验证结果
已通过:
cargo fmt --all -- --check;git diff --check;cargo test -p codexmanager-service --lib codex_profile::tests --no-fail-fast— 29 passed;cargo test -p codexmanager-service --test app_settings --no-fail-fast— 35 passed;pnpm -C apps run test:runtime— 216 passed;pnpm -C apps run build:desktop。完整 service lib 验证为
1532 passed / 1 failed / 3 ignored。唯一失败为现有codex_skills::tests::directory_import_detects_same_size_file_replacement_and_fifo_entries的跨平台 FIFO/路径断言,与本 PR 修改文件无关;目标 profile 与 app settings 回归均通过。兼容性
requires_openai_auth;