fix: Use system Abseil on MacOS if available, improve isolation of bundled linking, fix some deprecation warnings - #306
Merged
Conversation
paleolimbot
changed the title
paleolimbot
marked this pull request as ready for review
September 23, 2026 04:01
Collaborator
Author
|
Merging to see if we can't fix the r-universe build! |
Member
|
Fantastic! I'll pull it through win-builder and mac-builder and if all is good will submit to CRAN in the morning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an earlier observation that the recipes Abseil wasn't getting used on the CRAN MacOS builder (and also that homebrew Abseil wasn't used on a usual MacOS dev machine).
Also applies a patch from Simon that lets the bundled build pass on the CRAN MacOS runner even with the bundled build (does a better job isolating the bundled libraries)
Also fixes some deprecation warnings that were trivial to fix.