Port five concrete-boundary tests from rain.extrospection PR 50 - #2
Conversation
Upstream rain.extrospection PR 50 (merged at 7192796) added five tests pinning the concrete Extrospect's delegation routing, after this repo's test copies were taken. rain.extrospection PR 131 deletes them upstream, so this repo is their only future home. Ported byte-exactly from upstream commit 719279616ccdd24d61668c0843ded7cb56105cc5, with imports adapted to the rain-extrospection-0.1.6/ prefix: - testCheckNotEOFBytecodeMetamorphicButNotEOF - testIsERC1167ProxyConcreteImplementationAddress - testIsERC1167ProxyEquivalenceEOF - testScanEVMOpcodesPresentInBytecodeUnreachableCreateCounted - testScanEVMOpcodesReachableInBytecodeUnreachableCreateNotCounted SOLIDITY_CBOR_RUNTIME_FIXTURE_TRIMMED is deliberately not ported: its only upstream consumers are test/src/lib/* tests that do not exist here, and no ported or existing concrete test references it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 19 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Port five concrete-boundary tests from rain.extrospection PR 50
Upstream rain.extrospection PR 50 (merged, commit
719279616ccdd24d61668c0843ded7cb56105cc5) added five tests pinning the concreteExtrospect's delegation routing — added upstream after this repo's test copies were taken. rain.extrospection PR 131 deletes them upstream, so this repo is their only future home.Ported byte-exactly from the upstream commit (NatSpec preserved — it states repo-local routing facts that hold identically here), with imports adapted to the
rain-extrospection-0.1.6/prefix:test/src/concrete/Extrospect.checkNotEOFBytecode.t.soltestCheckNotEOFBytecodeMetamorphicButNotEOFtest/src/concrete/Extrospect.isERC1167Proxy.t.soltestIsERC1167ProxyConcreteImplementationAddresstest/src/concrete/Extrospect.isERC1167Proxy.t.soltestIsERC1167ProxyEquivalenceEOFtest/src/concrete/Extrospect.scanEVMOpcodesPresentInBytecode.t.soltestScanEVMOpcodesPresentInBytecodeUnreachableCreateCountedtest/src/concrete/Extrospect.scanEVMOpcodesReachableInBytecode.t.soltestScanEVMOpcodesReachableInBytecodeUnreachableCreateNotCountedSOLIDITY_CBOR_RUNTIME_FIXTURE_TRIMMEDis deliberately NOT ported: its only upstream consumers aretest/src/lib/*tests that do not exist in this repo, and no ported or existing concrete test references it — the existing CBOR tests derive trimmed bytes viatryTrimSolidityCBORMetadataon purpose. Porting it would add dead code.QA
nix develop -c forge testfull suite green (running; results folded in below)pre-commit run --all-filescleanQA results will be appended to this body when the runs complete.
🤖 Generated with Claude Code