soldeerignore .gas-snapshot: the sensitive-file prompt kills headless publishes - #60
Merged
Merged
Conversation
…le prompt, which hangs headless publishes PR #59 introduced .gas-snapshot; soldeer's sensitive-file prompt fired on it during the main publish and died on closed stdin ('not connected'), failing Package Release twice. rain.extrospection's .soldeerignore already excludes it; aligned. Verified by dry-run: the zip now carries src/, test/, LICENSE(S), README only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe Soldeer ignore list now excludes ChangesIgnore list update
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package Release on main has failed twice since PR #59 merged, both with soldeer's
error during IO operation for "": not connectedimmediately after "You are about to include some sensitive files in this version". That is the interactive sensitive-file prompt dying on closed stdin in headless CI — the exact failure the org's roh SKILL.md warns about. The trigger is.gas-snapshot, introduced by #59 and not in this repo's.soldeerignore(which predates the file); rain.extrospection's ignore file already excludes it, and its publishes are healthy.One line:
.gas-snapshotadded to.soldeerignore, matching the extrospection precedent. Verified byforge soldeer push --dry-run: the zip now carriessrc/,test/, LICENSE(S) and README only. Merging this retriggers Package Release on the push, which should publish the blockedrain-factory0.1.9 (PR #58+#59 content).QA
.gas-snapshotincluded; after: absent).soldeerignore(the org precedent that publishes cleanly with a.gas-snapshotpresent) and the failing runs' own logs; the dry-run zip listing is independent of the change's author🤖 Generated with Claude Code
Summary by CodeRabbit