Skip to content

Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335) - #137

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-08-19-drop-release-metadata
Aug 20, 2026
Merged

Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335)#137
thedavidmeister merged 1 commit into
mainfrom
2026-08-19-drop-release-metadata

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Drops the legacy [package] release-metadata section from foundry.toml, per the ruling on rainlanguage/rainix#335. Since rainlanguage/rainix#336 merged, rainix-autopublish derives the publish version from the Soldeer registry + next-v* git tags and never reads this section, and the publish gate excludes the section (including any attached comment block) from the content hash — so this deletion is content-neutral: it cannot mint a spurious release and changes no behavior. Verified locally: nix develop -c reuse lint (compliant), forge soldeer install, then forge test — the suite is green except 15 fork tests in test/lib/deploy/LibMetaBoardDeploy.t.sol that fail locally on vm.envString: environment variable not found (ETH/ARBITRUM/BASE/BASE_SEPOLIA/FLARE/POLYGON RPC URLs); those need CI-provided RPC secrets and are unrelated to this diff (the [rpc_endpoints] section they use is untouched). Excluding that file: 11 passed, 0 failed; within it, the 9 non-fork tests pass. CI runs the fork tests with its secrets.

QA

  • Discriminating tests: n/a - config-metadata deletion; nothing reads the section since rainix#336 (local nix develop -c forge test: green except 15 fork tests failing only on locally missing RPC env vars; reuse lint compliant)
  • Mutations applied: n/a - no code changed
  • Oracle: rainix#336 gate semantics (section excluded from content hash; version from registry + next-v tags)
  • Category check: issue asks removal of release metadata from consumers; covered exactly for this repo

Summary by CodeRabbit

  • Chores
    • Removed package metadata from the project configuration.
    • Existing build profiles, dependencies, network connections, and verification settings remain unchanged.

…gs (rainix#335)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5fb28fcf-6a52-409b-9f0a-28c8bf8a26b2

📥 Commits

Reviewing files that changed from the base of the PR and between 382d44e and aad0ea1.

📒 Files selected for processing (1)
  • foundry.toml
💤 Files with no reviewable changes (1)
  • foundry.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change removes the [package] metadata block from foundry.toml. Other Foundry settings remain unchanged.

Changes

Cohort / File(s) Summary
Foundry metadata
foundry.toml
Removes the package name and version metadata while preserving the remaining Foundry configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to aad0e

This change removes unused release metadata from foundry.toml without changing publish behavior or runtime code. No actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes removing foundry.toml release metadata and identifies next-v tags as the source of version intent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-08-19-drop-release-metadata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

SIZE=S

You are interacting with an AI system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant