Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335) - #137
Conversation
…gs (rainix#335) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe change removes the Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes unused release metadata from foundry.toml without changing publish behavior or runtime code. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
|
Tip For best results, initiate chat on the files or code changes. SIZE=S You are interacting with an AI system. |
Drops the legacy
[package]release-metadata section from foundry.toml, per the ruling on rainlanguage/rainix#335. Since rainlanguage/rainix#336 merged, rainix-autopublish derives the publish version from the Soldeer registry +next-v*git tags and never reads this section, and the publish gate excludes the section (including any attached comment block) from the content hash — so this deletion is content-neutral: it cannot mint a spurious release and changes no behavior. Verified locally:nix develop -c reuse lint(compliant),forge soldeer install, thenforge test— the suite is green except 15 fork tests intest/lib/deploy/LibMetaBoardDeploy.t.solthat fail locally onvm.envString: environment variable not found(ETH/ARBITRUM/BASE/BASE_SEPOLIA/FLARE/POLYGON RPC URLs); those need CI-provided RPC secrets and are unrelated to this diff (the[rpc_endpoints]section they use is untouched). Excluding that file: 11 passed, 0 failed; within it, the 9 non-fork tests pass. CI runs the fork tests with its secrets.QA
nix develop -c forge test: green except 15 fork tests failing only on locally missing RPC env vars;reuse lintcompliant)Summary by CodeRabbit