Skip to content

filePrefix stops explaining why the file is committed #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 2 commits into from
Aug 13, 2026
Merged

filePrefix stops explaining why the file is committed #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f571c7f
fix(codegen): filePrefix stops explaining why the file is committed
thedavidmeister Aug 13, 2026
0308aee
docs(codegen): drop the meta-commentary about the removed rationale
thedavidmeister Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/generated/CodeGennable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ pragma solidity ^0.8.25;

// THIS FILE IS AUTOGENERATED BY THE BUILD SCRIPT. DO NOT EDIT BY HAND.

// It is committed to the repository because there is a circular dependency
// between the contract and its generated file. The contract needs the
// generated file to exist so that it can compile, and the generated file
// needs the contract to exist so that it can be compiled.

/// @dev Hash of the known bytecode.
bytes32 constant BYTECODE_HASH = bytes32(0x8016e5305d25be28ac4d72616cfd999756e36eded3ec88562375e2e1c9eca84d);

Expand Down
6 changes: 1 addition & 5 deletions src/lib/LibCodeGen.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ library LibCodeGen {
"// SPDX-License-Identifier: LicenseRef-DCL-1.0\n"
"// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd\n"
"pragma solidity ^0.8.25;\n\n",
"// THIS FILE IS AUTOGENERATED BY THE BUILD SCRIPT. DO NOT EDIT BY HAND.\n\n"
"// It is committed to the repository because there is a circular dependency\n"
"// between the contract and its generated file. The contract needs the\n"
"// generated file to exist so that it can compile, and the generated file\n"
"// needs the contract to exist so that it can be compiled.\n"
"// THIS FILE IS AUTOGENERATED BY THE BUILD SCRIPT. DO NOT EDIT BY HAND.\n"
);
//REUSE-IgnoreEnd
}
Expand Down
6 changes: 1 addition & 5 deletions test/lib/LibCodeGen.filePrefix.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,7 @@ contract LibCodeGenFilePrefixTest is Test {
LibCodeGen.filePrefix(),
"// SPDX-License-Identifier: LicenseRef-DCL-1.0\n"
"// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd\n"
"pragma solidity ^0.8.25;\n\n" "// THIS FILE IS AUTOGENERATED BY THE BUILD SCRIPT. DO NOT EDIT BY HAND.\n\n"
"// It is committed to the repository because there is a circular dependency\n"
"// between the contract and its generated file. The contract needs the\n"
"// generated file to exist so that it can compile, and the generated file\n"
"// needs the contract to exist so that it can be compiled.\n"
"pragma solidity ^0.8.25;\n\n" "// THIS FILE IS AUTOGENERATED BY THE BUILD SCRIPT. DO NOT EDIT BY HAND.\n"
);
//REUSE-IgnoreEnd
}
Expand Down
Loading