Skip to content

Delete the longhand copy of assertRejected #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 1 commit into from
Aug 16, 2026
Merged

Delete the longhand copy of assertRejected #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions test/lib/LibCodeGen.requireContractName.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ contract LibCodeGenRequireContractNameTest is Test {
this.callRequireContractName(name);
}

/// Rejection is asserted as the whole error, selector and argument: every
/// rejection below pins that the revert carries the name that was rejected,
/// so a build script that generates many files says which one it choked on.
function assertRejected(string memory name) internal {
vm.expectRevert(abi.encodeWithSelector(InvalidContractName.selector, name));
this.callRequireContractName(name);
Expand Down Expand Up @@ -119,13 +122,6 @@ contract LibCodeGenRequireContractNameTest is Test {
assertRejected(string(hex"466f6f00"));
}

/// The rejection carries the name that was rejected, so a build script that
/// generates many files says which one it choked on.
function testRequireContractNameErrorCarriesTheName() external {
vm.expectRevert(abi.encodeWithSelector(InvalidContractName.selector, "sub/Foo"));
this.callRequireContractName("sub/Foo");
}

/// Accepting a name is exactly accepting every one of its bytes, so an
/// accepted name can be rebuilt from the identifier alphabet and nothing
/// else. Fuzzed so that the check is not merely rejecting the handful of
Expand Down
Loading