Skip to content

Float the suites declaration's pragma, as every other abstract here does - #2842

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-08-23-suites-pragma
Open

Float the suites declaration's pragma, as every other abstract here does#2842
thedavidmeister wants to merge 1 commit into
mainfrom
2026-08-23-suites-pragma

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

src/abstract/RaindexDeploySuites.sol was the only abstract in this repo pinned with =0.8.25; the other five float ^0.8.19, and all four of the org's conforming deploy repos float ^0.8.25 on the same file.

It is published: .soldeerignore drops script/ and test/ but ships src/, so a consumer that inherits this declaration inherits the pin with it — an exact pin on a shipped abstract forces every downstream repo onto 0.8.25 exactly.

The org convention (documented in the standard derived from rain.deploy and its four conforming consumers): concretes, scripts and tests pin =0.8.25; libraries, abstracts and generated files float ^0.8.25 so downstream consumers on another 0.8.x still compile.

Written as part of the deploy-standard conformance work on #2841; it missed that PR's merge by a few minutes, hence this follow-up. No other conformance work is outstanding from that audit — the rest landed in 93377dee1.

QA

  • Discriminating tests: n/a — a pragma directive has no runtime behaviour to test. The compiler is the check: the repo builds under solc 0.8.25 before and after, and forge fmt --check and rainix-sol/static pass on the change.
  • Mutations applied: n/a — no logic in the diff; the only possible mutation is a different pragma, which either compiles identically or fails the build outright.
  • Oracle: the convention as observed in the other five abstracts in this repo and in the same file across rain.math.float.deploy, rain.extrospection.deploy, rain.factory.deploy and rain.metadata.deploy — all four float it. Independent of anything in this diff.
  • Category check: no linked issue; the work order was deploy-standard conformance. This covers the one axis that missed Cut release 0.1.14: freeze candidate pins, target the standard seven networks #2841's merge. Deferred elsewhere with reasons on Cut release 0.1.14: freeze candidate pins, target the standard seven networks #2841: currency-workflow naming, committed remappings.txt, test/abstract/ layout, the 36 files importing rain-deploy-0.1.2/… via the foundry.toml alias, and the missing <Thing>DeploySuitesTest.

`src/abstract/RaindexDeploySuites.sol` was the only abstract in this repo
pinned with `=`; the other five float `^0.8.19`, and all four of the org's
conforming deploy repos float `^0.8.25` on the same file. It is published:
`.soldeerignore` drops `script/` and `test/` but ships `src/`, so a consumer
that inherits this declaration inherits the pin with it.

No bytecode moves. `foundry.toml` pins `solc = "0.8.25"`, and the concretes
and scripts that inherit this still pin `=0.8.25` themselves, so the compiler
this is built with is unchanged either way.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@thedavidmeister, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ecb22b58-0245-4523-a79c-88cae9f9ca2d

📥 Commits

Reviewing files that changed from the base of the PR and between 5984fb5 and 16bd422.

📒 Files selected for processing (1)
  • src/abstract/RaindexDeploySuites.sol

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant