Use default_factory for WeightedEnsemble.metadata - #48
Merged
Conversation
The field was declared with default=IterationMetadata, which assigns the class object itself as the default rather than constructing an instance. Any WeightedEnsemble built without an explicit metadata argument carried the class, so attribute access such as .iteration returned the field descriptor instead of the current iteration id. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WeightedEnsemble.metadatawas declared as:default=assigns the class object as the default value rather than constructing an instance, so anyWeightedEnsemblecreated without an explicitmetadataargument carriesIterationMetadatathe class.self.metadata.iteration_idthen reads an attribute off the class instead of a real iteration id, and theiterationproperty returns something that is not anint.Switched to
default_factory=IterationMetadata, matching howcur_simsandnext_simsare already declared in the same model.Also tightened the
iterationdocstring to note the value is 1-indexed.Extracted from #40 so it can land on its own.
🤖 Generated with Claude Code