Handle null failure_info in print_errors - #50
Merged
Conversation
Result records can carry an explicit null failure_info rather than omitting the key. The membership test treated that as present and the subsequent lookup on None raised, so print_errors died partway through a run directory instead of reporting the failures it had found. Read the field with .get and check it is not None before indexing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
print_errorswalked result records with:Records can carry an explicit
nullfailure_inforather than omitting the key. The membership test treats that as present, and the following lookup runsinagainstNone, raisingTypeError. The command died partway through the run directory instead of reporting the failures it had already found.Now reads the field with
.getand checks it is notNonebefore indexing. Also adds comments and normalizes the f-string quoting to match the rest of the file.Extracted from #40 so it can land on its own.
🤖 Generated with Claude Code