rust based bash completion - #272
Merged
Merged
Conversation
ddiss
commented
May 29, 2026
Collaborator
This is basically a rust conversion of the tools/bash_completion script. It's usable via: complete -C $(realpath target/release/bash-completion) rapido The main motivation for this conversion is distribution packaging: we want to be able to set things like the rapido cut script path at build time. One other benefit is that we can add some unit test coverage. Completion outputting functions carry an @out parameter, which tests can use to capture completion output. Signed-off-by: David Disseldorp <ddiss@suse.de>
Capture the complete_rapido() output and compare it with what's expected. The cut-script completion logic assumes that the test is run from the parent rapido directory. Signed-off-by: David Disseldorp <ddiss@suse.de>
Collaborator
Author
|
Looks like there's an issue with the old |
Remove the old bash __rapido() completion helper function and call the new bash-completion.rs binary instead. Look under the script relative ../target/release path for it. Signed-off-by: David Disseldorp <ddiss@suse.de>
Collaborator
Author
All it needed was a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.