Fix undeclared vars - #271
Merged
Merged
Conversation
sabberworm
reviewed
Jul 27, 2026
Member
There was a problem hiding this comment.
Suggested change
| $oIncluder->addJavaScriptLibrary($this->aLibraryName, $this->sVersion, $this->bUseCompression, false, false, ResourceIncluder::PRIORITY_NORMAL, false); |
sabberworm
reviewed
Jul 27, 2026
| <?php | ||
|
|
||
| class LocalJsLibraryFileModule extends FileModule { | ||
| private $aLibraryName; |
Member
There was a problem hiding this comment.
Wollen wir das auch gleich zu sLibraryName angleichen?
sabberworm
reviewed
Jul 28, 2026
| // Don’t use SSL for downloads | ||
| // Don’t include dependencies either | ||
| $oIncluder->addJavaScriptLibrary($this->aLibraryName, $this->aVersion, $this->bUseCompression, false, false, ResourceIncluder::PRIORITY_NORMAL, false); | ||
| $oIncluder->addJavaScriptLibrary($this->sLibraryName, $this->aVersion, $this->bUseCompression, false, false, ResourceIncluder::PRIORITY_NORMAL, false); |
Member
There was a problem hiding this comment.
Da steht immer noch $this->aVersion statt $this->sVersion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hallo Rafi, habe hier undeklarierte Variablen dek... Glaube das kann man mergen?!
Danke.