splashasm: Add port option and bump version - #212
SherbertLemon64 wants to merge 2 commits into
Conversation
121a52d to
0cb7f4a
Compare
|
I've also realised that the previous model of limiting pin choice doesn't really work unless I am willing to list out all the spi pins on RP1, I've downgraded it to a warning now, but I'll have a think whether it is work maintaining a pin map here or not |
| Port : Sets the output block we will be writing to, this | ||
| needs to be in agreement with the pins to get an | ||
| output. Not relevant for Pis earlier than the Pi 5 | ||
| Reserved : three pad bytes (struct alignment after Size), always |
With the rp1 support, the port cannot be assumed as there are now multiple usable ports. Add in a port option, since this is a silently breaking change, bump version
3e56c34 to
ea5cf39
Compare
|
Just removed the bit about it not supporting rp1 and squished it into my original commit |
|
Just also remembered a bug in the firmware that should be fixed on that side of things while this is going on. During development, the size of the length commands was 10 bits. I eventually changed it to 16 but didn't change the evaluation code for it so it errors if actually use more than the 10 bits. I could limit things on the generator side of things or auto split up commands but I think it makes sense to just support all 16 bits in the firmware |
|
The firmware side is currently held up because the RP1 I2C driver is moderately broken. |
|
I've updated your branch with some changes that should allow compatibility with old firmware unless new features are used. It also changes the value of CPOL, CPHA and CSPOL to the conventional 0 & 1 rather than the VC-specific 1 & 2. |
2 participants
With the rp1 support, the port cannot be assumed as there are now multiple usable ports. Add in a port option, since this is a silently breaking change, bump version
Do not merge until the firmware is updated