RDBC-1121 Add connectionStreamTimeout to subscription worker options - #590
Merged
Merged
Conversation
kalczur
approved these changes
Sep 24, 2026
Matches the C# SubscriptionWorkerOptions.ConnectionStreamTimeout (RavenDB-18031): default 30 seconds, minimum 15 seconds. The subscription socket is destroyed with a TimeoutException when no data is sent or received within that period, which fails the pending read and lets the worker reconnect. Ports Subscriptions_WithWaitForFree_ShouldNotDisconnectOnStreamTimeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDBC-1121
Description
connectionStreamTimeouttoSubscriptionWorkerOptions(default 30 s, minimum 15 s)InvalidArgumentException, matching the C# clientTimeoutExceptionafter that long without trafficSubscriptions_WithWaitForFree_ShouldNotDisconnectOnStreamTimeoutand add a validation testType of change
x.y.z->x.y.z)Target branch and backports
v7.2,v7.1,v7.0,v6.0)How risky is the change?
Backward compatibility
Server compatibility
Affected runtimes
Public API
src/index.ts(npm run check-exportspasses).package.jsonandCLIENT_VERSIONinsrc/Http/RequestExecutor.ts(sync / release PRs only)Documentation update
README.mdhas been updatedTesting by Contributor
npm run lint,npm run build,npm run check-exportsandnpm run check-importspass locallyRAVENDB_TEST_SERVER_PATH/RAVENDB_SERVER_VERSION)Dependencies
Is there any existing behavior change of other features due to this change?