Skip to content

Dry run before publishing - #85

Open
mabadir wants to merge 5 commits into
mainfrom
ma/publish-dry-run
Open

Dry run before publishing#85
mabadir wants to merge 5 commits into
mainfrom
ma/publish-dry-run

Conversation

@mabadir

@mabadir mabadir commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR makes global definition publication contingent on successfully validating and creating the first version.

  • Tracks whether remote definitions are already globally published.
  • Defers global publication until first-version validation and creation succeed.
  • Adds plans and tests for new and existing private definitions.

Confidence Score: 4/5

The publication-ordering fix appears sound, but the outstanding incomplete-plan behavior should be fixed before merging.

Release-status conflicts still produce a result with no planned items, and the formatter returns after showing only those conflicts, so reviewers cannot inspect otherwise valid releases in the same run.

Files Needing Attention: tools/ravion-modules/src/publish.ts

Important Files Changed

Filename Overview
tools/ravion-modules/src/generate-definitions.ts Extends remote definition data with optional global-publication state.
tools/ravion-modules/src/publish.ts Defers global publication until the first version is validated and confirmed.
tools/ravion-modules/test/publish.test.ts Adds coverage for validation and publication ordering across new and private definitions.

Sequence Diagram

sequenceDiagram
  participant CLI
  participant API
  CLI->>API: Create private definition
  CLI->>API: Dry-run first version
  API-->>CLI: Validation succeeds
  CLI->>API: Create first version
  API-->>CLI: Version confirmed
  CLI->>API: Publish definition globally
Loading

Reviews (2): Last reviewed commit: "Merge branch 'main' into ma/publish-dry-..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Ravion Module Publish Plan

Dry run only. No Ravion API mutations were made.

No publish changes are required. All versions already exist with identical config.

Comment thread tools/ravion-modules/src/publish.ts Outdated
Comment thread tools/ravion-modules/src/publish.ts Outdated
Comment thread tools/ravion-modules/test/publish.test.ts Outdated
mabadir added 2 commits August 4, 2026 14:22
Delay isGlobalPublished until remote validation and version creation
succeed, so a rejected config no longer leaves a published definition
with no version. Also apply the same visibility patch when an
existing private definition's version is confirmed or created, and
plan the patch in dry-run output. Keep validation failures from
hiding other modules' plan items in the markdown output.
@mabadir

mabadir commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

@greptile

@mabadir
mabadir requested a review from flybayer August 10, 2026 19:56
@mabadir
mabadir force-pushed the ma/publish-dry-run branch from ac4ead0 to 868c379 Compare August 10, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants