fix: align Trisomy 21 BMI upper bound - #110
Open
pacharanero wants to merge 1 commit into
Open
pacharanero wants to merge 1 commit into
pacharanero wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LookupErrorpath and corrected message.math.nextafter()beyond the endpoint.Source evidence
The canonical source workbook
rcpch/growth-references/trisomy21/UKReference/LMS_Downs.xlsxcontains BMI LMS values for both sexes at 18.83 and 18.92 years, then blank BMI cells from 19.00 onward. The packagedtrisomy_21.jsonaccurately contains those same final two rows.The previous
18.82guard did not correspond to a source-table age and made both final rows unreachable. This PR changes no reference values.Follow-up
Issue #109 and roadmap item R25 track replacing duplicated age literals across all references with validated source/applicability metadata. That work must distinguish raw table extent from clinical applicability and hybrid-reference overlap policy.
Verification
s/test --running -q: 145161 passedgit diff --check: passed