Skip to content

Add Jupyter Notebook output - #124

Open
avsm wants to merge 1 commit into
realworldocaml:mainfrom
avsm:jupyter
Open

Add Jupyter Notebook output#124
avsm wants to merge 1 commit into
realworldocaml:mainfrom
avsm:jupyter

Conversation

@avsm

@avsm avsm commented Apr 14, 2019

Copy link
Copy Markdown
Member

This is a WIP; creating a PR to make it easy for @jonludlam and me to push to our forks

  • detect and reject multiple environments in one notebook (or figure out how to make them work in Jupyter)

@avsm

avsm commented Sep 13, 2019

Copy link
Copy Markdown
Member Author

Some quality of life improvements: supports Markdown sections and raw cells now

@avsm

avsm commented Sep 21, 2019

Copy link
Copy Markdown
Member Author

Noticed a problem that causes divergence between mdx evaluation and Jupyter. The latter doesn't support multiple environments, so having two OCaml environments will cause them to be silently merged into one with the PR.

@craigfe

craigfe commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

I have a rebased form of this PR at CraigFe/jupyter if you do decide to go ahead with this.

@avsm

avsm commented Sep 3, 2020

Copy link
Copy Markdown
Member Author

thanks, I've pushed your rebase here. @NathanReb we could go ahead with merging this; the only restriction it would be nice to have before that is to ensure that there is only one environment per notebook.

@craigfe

craigfe commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

From playing around with this PR, I noticed that it doesn't yet support file includes. I have a fairly hacky patch for that here, but it probably warrants a cleaner implementation (that doesn't just fail for a large number of block types).

@avsm

avsm commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

Could we get this merged as an experimental feature @gpetiot, so that @craigfe's variant above can be tracked? It's already useful as-is despite the limitations.

@NathanReb
NathanReb changed the base branch from master to main July 2, 2021 09:47
@avsm

avsm commented Sep 16, 2021

Copy link
Copy Markdown
Member Author

rebased to current trunk

@gpetiot
gpetiot force-pushed the jupyter branch 4 times, most recently from 4338055 to c29c5ba Compare September 28, 2021 13:58
@gpetiot gpetiot changed the title add Jupyter output Add Jupyter Notebook output Sep 28, 2021
@avsm
avsm marked this pull request as ready for review October 15, 2021 12:03
Signed-off-by: Jon Ludlam <jon@recoil.org>
Coauthored-by: Anil Madhavapeddy <anil@recoil.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants