core-functional: flip 3 more tests (59→62) - #302
Merged
Conversation
added 3 commits
August 28, 2026 20:30
![rbitcoin-grok[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Treat --maxconnections as Core total slots (inbound = N-11) while --maxinbound stays an explicit inbound cap. When inbound is full, AttemptToEvictConnection-shaped protection picks an unprotected peer instead of silently rejecting the new connection (p2p_eviction).
Shim maps Core -bind=…=onion to extra --listen sockets. PeerHub samples addrman for GetAddr (≤1000 / 23%) and caches per bind for 24h so p2p_getaddr_caching sees stable same-bind replies and distinct bind samples.
Scan completed BIP9-style periods for unassigned signalling bits and surface Core's "Unknown new rules activated (versionbit N)" in get*info warnings arrays. Shell-escape -alertnotify %s so functional alert files receive the message.
rearden-grok
Bot
added
the
core-functional
added 2 commits
August 28, 2026 20:35
cargo fmt; drop alert_fired from RpcConfig test literals; expect onion -bind as an extra --listen in bitcoind.test.sh.
p2p_getaddr_caching issues 10k addpeeraddress RPCs; rewriting peers on each call blew the 20m core-functional wall. Durability stays on the node's existing shutdown/catch-up save paths.
rearden-grok
Bot
force-pushed
the
core/func-e9
branch
from
August 29, 2026 04:13
cf9af0b to
dc23f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-maxconnections=N→ inboundN−11; evict unprotected inbound at cap instead of rejecting.--listenfor onion binds; GetAddr samples addrman with per-bind 24h cache.-alertnotify.Inventory 59 → 62 run.
Test plan
p2p_eviction.pyPassed locallyp2p_getaddr_caching.pyPassed locallyfeature_versionbits_warning.pyPassed locallycore-functional+ required gates green