ibd: cap assign-stop densify to 1-min window - #305
Merged
Conversation
Assign-stop was filling holes out to fetched_hi, which ballooned the body queue when confirm stalled far behind a high fetched horizon. At/over stop, band_hi is now min(confirm_window_hi, fetched_hi, densify_hi) so densify stays in the ~1min tip-rate window and does not grow past fetched. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetched_hi.min(~1 min tip-rate window, fetched_hi, densify_hi)so confirm stalls cannot balloon the body queue by densifying a far sparse horizon.fetched_hi.Test plan
cargo test -p rbitcoin-query soft_densifycargo test -p rbitcoin-net densify_over_assign_stopMade with Cursor