ibd: densify download by recent speed, not request age - #306
Closed
rearden-grok[bot] wants to merge 7 commits into
Closed
ibd: densify download by recent speed, not request age#306rearden-grok[bot] wants to merge 7 commits into
rearden-grok[bot] wants to merge 7 commits into
Conversation
Request age no longer clears every racer. Drop at most one owner of a hole when a sibling has stream rx or that owner is a half-median outlier among owners, so a slow local pipe can finish the block. Co-authored-by: Cursor <cursoragent@cursor.com>
Single-peer densify hashes with no stream rx for 30s move to a faster peer with a free slot. Slow-but-steady downloads stay put; a hung hash with no slot rewinds densify_scan_lo. Co-authored-by: Cursor <cursoragent@cursor.com>
New densify hashes follow the same speed rank as tip-hole cover instead of assign_rot round-robin, so unique work lands on pack leaders first. Slow peers still take leftover slots. Co-authored-by: Cursor <cursoragent@cursor.com>
collect_height_band must not run (and must not advance densify_scan_lo) when no alive peer has a densify slot, even if cfg.window still has room. Co-authored-by: Cursor <cursoragent@cursor.com>
Lifetime speed_sample stays for AddrMan on disconnect. Ranking and relative-slow disconnect use complete-block bytes over up to ~60s so a historically-fast idle peer no longer hoards unique getdata. Co-authored-by: Cursor <cursoragent@cursor.com>
Default densify cap stays 8 (2 while a tip hole is open). A peer gets the full 16 only when recent bps is at least twice the pack median and the pack is not a tight cluster, so slow peers cannot hoard unique hashes. Co-authored-by: Cursor <cursoragent@cursor.com>
Operator docs: no wall-clock whole-set abort; default densify 8, full 16 only for a 2×-median outlier. Assign pins that densify past fetched take the same env lock as the assign-stop test so parallel cargo test does not clip the band. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Superseded by |
Contributor
Author
|
Closing without merge; work continues on ibd/peer-rate-ewma. |
3 tasks
Contributor
Author
|
Superseded by #308 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hole>0still drips 2. A tight slow pack (local bottleneck) keeps its getdata.speed_sampleremains for AddrMan on disconnect.Test plan
cargo test -p rbitcoin-net --lib cover_tip_holescargo test -p rbitcoin-net --lib densify_cargo test -p rbitcoin-net --lib relative_slowfmt,deny,clippy,ast-grep,test,windows,macos,multinode,coverage)Made with Cursor