Skip to content

fix: optional Postgres via compose-with-db overlay - #276

Draft
zdrapela wants to merge 2 commits into
docs/pg16-to-pg18-upgradefrom
fix/RHDHBUGS-1865-compose-with-db
Draft

fix: optional Postgres via compose-with-db overlay#276
zdrapela wants to merge 2 commits into
docs/pg16-to-pg18-upgradefrom
fix/RHDHBUGS-1865-compose-with-db

Conversation

@zdrapela

Copy link
Copy Markdown
Member

Description

Fixes RHDHBUGS-1865: enabling the optional PostgreSQL service no longer requires uncommenting blocks in the default compose.yaml (which caused merge conflicts on pull).

  • Add compose-with-db.yaml overlay (same pattern as compose-with-corporate-proxy.yaml / compose-dynamic-plugins-root.yaml)
  • Point compose.yaml at the overlay instead of a commented db service
  • Update the PostgreSQL guide for -f compose.yaml -f compose-with-db.yaml, including a combined example with compose-with-corporate-proxy.yaml
  • Point major-upgrade steps at compose-with-db.yaml and dual -f compose commands

Stacked on #275 (docs/pg16-to-pg18-upgrade). Retarget to main after #275 merges.

Which issue(s) does this PR fix or relate to

PR acceptance criteria

  • Tests updated and passing
  • Documentation updated
  • Built-in TechDocs updated if needed. Note that TechDocs changes may need to be reviewed by a Product Manager and/or Architect to ensure content accuracy, clarity, and alignment with user needs.

How to test changes / Special notes to the reviewer

  1. Do not edit compose.yaml for Postgres
  2. podman login registry.redhat.io
  3. Copy POSTGRES_* into .env; switch app-config.local.yaml from SQLite to pg as in the guide
  4. podman compose -f compose.yaml -f compose-with-db.yaml up -ddb healthy, RHDH up
  5. Optional: podman compose -f compose.yaml -f compose-with-db.yaml -f compose-with-corporate-proxy.yaml config merges db + proxy + rhdh.depends_on
  6. npx --yes dclint compose-with-db.yaml → 0 errors

Made with Cursor

Avoid editing tracked compose.yaml for PostgreSQL by adding a
compose-with-db.yaml merge file, matching other optional overlays.
Pin db image via POSTGRES_IMAGE and keep temporary POSTGRESQL_UPGRADE
in a gitignored override so users never edit tracked compose-with-db.yaml.
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant