Do not print an empty table when every addon is up to date - #55
Merged
Conversation
Without -v the status table only receives addons that need attention, so when everything was up to date the command printed a table frame with nothing but headers above the summary line. The empty frame carries no information and reads as "nothing is tracked" - a user filed exactly that misreading as part of #52. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 583 584 +1
Branches 97 98 +1
=========================================
+ Hits 583 584 +1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
-vthe status table only receives addons that need attention, so when everything is up to date the command printed a table frame containing nothing but headers, followed by the summary line.Before:
After:
The empty frame carries no information and reads as "nothing is tracked". That is not hypothetical — the reporter in #52 hit exactly this after his addons updated cleanly and filed it as DBM having disappeared from
status.Output is unchanged whenever the table has rows, and the summary keeps its
otherqualifier:status -vstill lists every addon, up-to-date ones included.The
No addons foundguard for an empty addon directory is untouched — that is a different case from "everything is up to date".🤖 Generated with Claude Code