feat: support array targeting and evaluation diagnostics - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the relevant array-targeting and diagnostic changes from the Node SDK (JavaScript PRs #711, #714, and #724):
FlattenJsonbehavior.evalErrorsin check telemetry andevaluationErrorsin bootstrap JSON, retaining legacy missing-field metadata.Canonical context deduplication is intentionally a separate, independent PR. This SDK has no remote evaluation/config-check API; the Node signal-interception fix requires no .NET lifecycle change.
Release prerequisite
Do not release until the ingest service supports
evalErrors, matching the rollout prerequisite in JavaScript PR #724. Invalid rules that previously matched through negation/OR now fail closed; this behavior change is documented.Validation
dotnet build dotnet-sdk.sln -c Release: zero warnings/errors; library builds for .NET 10 and .NET Standard 2.0.dotnet test dotnet-sdk.sln -c Release --no-build: 332 passed (161 SDK + 5 example tests on each of .NET 8 and .NET 10).git diff --checkpassed.