Skip to content

Fix opt-in error responses and SDK documentation - #729

Merged
roncohen merged 9 commits into
mainfrom
fix/opt-in-response-and-docs
Sep 15, 2026
Merged

Fix opt-in error responses and SDK documentation#729
roncohen merged 9 commits into
mainfrom
fix/opt-in-response-and-docs

Conversation

@roncohen

@roncohen roncohen commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Preserve failed setOptIn() response bodies by logging a cloned response, with regression coverage for readable errors, unchanged flags, and no refresh on HTTP failure.
  • Keep the manual-refresh recovery test after failed opt-in metadata loading.
  • Simplify Browser/React/Vue examples to response checking and error handling. React/Vue examples retain explicit loading checks without mutation pending state or error UI.
  • Use concise README return-value guidance: “Returns a Response, or undefined if skipped due to invalid input, offline mode etc. Check response?.ok for success.” Detailed mutation semantics remain in the API reference.
  • Condense metadata retry guidance and retain the corrected browser-context bootstrap warning, loading distinctions, and Suspense clarification.
  • Correct opt-in API comments and retain tested generated-reference fixes for imported type aliases and optional properties/parameters.
  • Include a Browser SDK patch changeset.

Authorization warnings are excluded. No hook API changes or new loading/retry behavior are introduced.

Validation

Rechecked after the simplifications:

  • Browser client tests: 39 passed.
  • Documentation postprocessor tests: 3 passed.
  • Formatting checks and git diff --check passed.

Related documentation

reflagcom/docs#29

Copilot AI lite review requested due to automatic review settings September 11, 2026 12:59
@roncohen roncohen mentioned this pull request Sep 11, 2026
Open
Copilot AI reviewed Sep 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 15, 2026 08:19
Copilot AI reviewed Sep 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@roncohen
roncohen added this pull request to the merge queue Sep 15, 2026
Copilot AI review requested due to automatic review settings September 15, 2026 08:24
Copilot AI reviewed Sep 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@roncohen
roncohen removed this pull request from the merge queue due to a manual request Sep 15, 2026
Copilot AI review requested due to automatic review settings September 15, 2026 08:29
Copilot AI reviewed Sep 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 15, 2026 08:30
Copilot AI reviewed Sep 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 15, 2026 08:32
Copilot AI reviewed Sep 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 15, 2026 08:34
Copilot AI reviewed Sep 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 15, 2026 08:34
Copilot AI reviewed Sep 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@roncohen
roncohen added this pull request to the merge queue Sep 15, 2026
Merged via the queue into main with commit 4649418 Sep 15, 2026
7 of 8 checks passed
@roncohen
roncohen deleted the fix/opt-in-response-and-docs branch September 15, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roncohen