fix(browser-sdk): clean up Preact roots before test teardown - #745
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Both #739 and #742 were ejected from the merge queue after all 205 browser assertions passed: a delayed Preact toolbar render accessed sessionStorage after jsdom teardown. client.stop() does not unmount the UI; removing DOM nodes alone does not cancel Preact work.
Fix
Validation
ReferenceError: sessionStorage is not definedwhenrender(null, host.shadowRoot)is omitted (even when the host DOM node is removed)./tmp/reflag-flake-linux/repro-baseline/{1..40}.logand/tmp/reflag-flake-linux/repro-fixed/{1..40}.log; fixed exit codes are inrepro-fixed/results.txt.node:24.13.0-bookworm, Docker--cpus=2, immutable root install, then repeatedly runCI=true yarn vitest run --reporter=defaultfrompackages/browser-sdk. Native macOS runs did not reproduce the exact error, so the before/after counts above are exclusively Linux.Follow-up: once merged, requeue #739 and #742.