Skip to content

refactor(flag-evaluator): align evaluation error terminology - #749

Open
roncohen wants to merge 4 commits into
mainfrom
refactor/evaluation-diagnostic-terminology
Open

refactor(flag-evaluator): align evaluation error terminology#749
roncohen wants to merge 4 commits into
mainfrom
refactor/evaluation-diagnostic-terminology

Conversation

@roncohen

@roncohen roncohen commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • standardize internal evaluation naming on “error” across the evaluator, browser SDK, and Node SDK
  • preserve the existing EvaluationError type and errors, evaluationErrors, and evalErrors fields unchanged
  • clarify the error emitted when flags are evaluated before initial flag state is available

Validation

  • packages/flag-evaluation: 248 tests and TypeScript build
  • packages/browser-sdk: 29 focused tests and TypeScript check
  • packages/node-sdk: 132 tests and TypeScript check
  • oxlint, oxfmt, and git diff --check

Review

  • completed a simplification/refactor pass
  • completed a final diff review; no actionable findings

Stacked on #748.

Copilot AI lite review requested due to automatic review settings September 24, 2026 19:39
Copilot AI reviewed Sep 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@roncohen
roncohen force-pushed the refactor/evaluation-diagnostic-terminology branch from 745fc10 to 58490cd Compare September 25, 2026 10:06
Copilot AI review requested due to automatic review settings September 25, 2026 10:06
@roncohen roncohen changed the title refactor: align evaluation diagnostic terminology refactor: align evaluation error terminology Sep 25, 2026
Copilot AI reviewed Sep 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 25, 2026 10:11
@roncohen
roncohen force-pushed the refactor/evaluation-diagnostic-terminology branch from 58490cd to 81f835c Compare September 25, 2026 10:11
Copilot AI reviewed Sep 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@roncohen
roncohen force-pushed the refactor/evaluation-diagnostic-terminology branch from 81f835c to 1942e3c Compare September 25, 2026 10:14
Copilot AI review requested due to automatic review settings September 25, 2026 10:14
Copilot AI reviewed Sep 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@roncohen roncohen changed the title refactor: align evaluation error terminology refactor(flag-evaluator): align evaluation error terminology Sep 25, 2026
Base automatically changed from fix/structured-evaluation-diagnostics to main September 25, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roncohen