Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Previously, an automatic flush cleared the buffer before delivery completed. A subsequent explicit flush could return immediately, allowing Lambda to freeze with bulk I/O still pending. Workers use waitUntil; Lambda handlers must await flush before returning.
This fixes a demonstrated lifecycle race, but is not yet confirmation of the reported customer timeout root cause. Both ReflagClient and EdgeClient share the affected buffer.
Validation
Scope
No automatic Lambda detection, timeout increases, external queue, or extension. The documented pattern awaits flush on every invocation; delivery failures remain logged and discarded.