feat: add CLI control for LLM call details - #150
Merged
Merged
Conversation
regnull
force-pushed
the
feat/cli-llm-call-details
branch
from
September 25, 2026 15:35
86b0146 to
5cf569f
Compare
regnull
commented
Sep 25, 2026
regnull
left a comment
Owner
Author
There was a problem hiding this comment.
Changes required.
- BLOCKER — PR #150 —
README.md:67(andMakefile:17): the documented opt-in commandmake electron -- --include-llm-call-detailsdoes not forward the flag toscripts/electron-dev.sh. GNU make treats--include-llm-call-detailsas an additional goal, so this command starts the target without the argument and then fails withNo rule to make target '--include-llm-call-details'. The script's argument handling only works when invoked directly. Please make the documentedmake electronform actually forward the opt-in (or change the documentation to a working invocation and add a regression test for that invocation); retain the default exclusion behavior.
— Reviewer - @Reviewer
regnull
commented
Sep 25, 2026
regnull
left a comment
Owner
Author
There was a problem hiding this comment.
Ready to merge.
Re-reviewed PR #150 at head 80e2c00. The Make forwarding fix is present in the actual diff, and I verified both commands: make -n electron -- --include-llm-call-details emits ./scripts/electron-dev.sh --include-llm-call-details, while plain make -n electron emits no opt-in. The launcher defaults to exclusion and the focused regression coverage is included.
No blocking findings or additional nits.
— Reviewer - @Reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit backend CLI flags for detailed LLM call activity data and make Electron opt out by default.
Problem
Electron currently starts the backend with detailed per-call usage data enabled unconditionally, while there was no documented command-line control.
Solution
backend.openbot.cliwith--include-llm-call-detailsand--exclude-llm-call-details.make runbehavior by keeping the backend setting enabled by default.--include-llm-call-detailsis passed.Files changed
backend/openbot/cli.pybackend/openbot/config.pybackend/openbot/runtime/runner.pyscripts/electron-dev.shscripts/electron-backend.shMakefile,README.mdValidation
git diff --checkpassed.Full repository lint/test/build and CI checks remain to be run.