feat: add openbot command launcher - #154
Merged
Merged
Conversation
regnull
commented
Sep 25, 2026
regnull
left a comment
Owner
Author
There was a problem hiding this comment.
Ready to merge.
Reviewed PR #154 at head 185a631. The launcher correctly validates and canonicalizes workspace/database directories, expands supported tilde paths, preserves paths containing spaces, forwards absolute workspace and SQLite database settings through the canonical make run path, and includes focused regression coverage. I found no blocking correctness issues.
NIT — openbot: the usage text initially says the database is DIRECTORY/.openbot/openbot.db, then says the database root defaults to ~/.openbot; the implementation and remainder of the help text use ~/.openbot, so clarify that first sentence to avoid misleading users.
— Reviewer - @Reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an executable
openbotcommand for starting the production-style OpenBot server with caller-selected workspace and database roots.Problem
Users currently need to know the repository's Makefile/backend invocation details and manually configure environment variables. This makes it difficult to start OpenBot from another directory or safely use workspace/database paths containing spaces.
Solution
openbotlauncher with clear--help/invalid-usage errors.--rootto the caller's current working directory.--db-rootto~/.openbot, creating it when needed.~/~/..., canonicalize accessible directories, preserve argument boundaries, and setWORKSPACE_ROOT/DATABASE_URLbefore delegating to the existingmake runstartup path.Files changed
openbotmake run.scripts/test_openbot.pymakeexecutable to inspect forwarded environment and arguments.Design decisions
The launcher intentionally does not duplicate backend initialization. It exports the same environment settings consumed by the existing backend and invokes
make run, keeping migrations, frontend build, and server startup in the established path.Validation
python3 -m unittest scripts/test_openbot.py— 6 passedbash -n openbot— passedmake lint— passed with existing frontend warnings and zero errorsmake test— backend 462 passed/19 deselected; frontend tests and typecheck passedmake build— passedCI will provide the final remote validation before review.